tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

gpio: max77759: drop use of irqd_get_trigger_type

irqd_get_trigger_type() is meant for cases where the driver needs to
know the configured IRQ trigger type and e.g. wants to change its
behaviour accordingly. Furthermore, platform support code, e.g. DT
handling, will configure the hardware based on that, and drivers don't
need to pass the trigger type into request_irq() and friends.

Drop the use from this driver, as it doesn't need to know the trigger
type.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/20251217-max77759-gpio-irq-trigger-v1-1-5738953c1172@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

authored by

André Draszik and committed by
Bartosz Golaszewski 9d810757 2b03d9a4

+2 -8
+2 -8
drivers/gpio/gpio-max77759.c
··· 435 435 int irq; 436 436 struct gpio_irq_chip *girq; 437 437 int ret; 438 - unsigned long irq_flags; 439 - struct irq_data *irqd; 440 438 441 439 chip = devm_kzalloc(&pdev->dev, sizeof(*chip), GFP_KERNEL); 442 440 if (!chip) ··· 484 486 return dev_err_probe(&pdev->dev, ret, 485 487 "Failed to add GPIO chip\n"); 486 488 487 - irq_flags = IRQF_ONESHOT | IRQF_SHARED; 488 - irqd = irq_get_irq_data(irq); 489 - if (irqd) 490 - irq_flags |= irqd_get_trigger_type(irqd); 491 - 492 489 ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, 493 - max77759_gpio_irqhandler, irq_flags, 490 + max77759_gpio_irqhandler, 491 + IRQF_ONESHOT | IRQF_SHARED, 494 492 dev_name(&pdev->dev), chip); 495 493 if (ret < 0) 496 494 return dev_err_probe(&pdev->dev, ret,