tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ice: add dpll peer notification for paired SMA and U.FL pins

SMA and U.FL pins share physical signal paths in pairs (SMA1/U.FL1 and
SMA2/U.FL2). When one pin's state changes via a PCA9575 GPIO write,
the paired pin's state also changes, but no notification is sent for
the peer pin. Userspace consumers monitoring the peer via dpll netlink
subscribe never learn about the update.

Add ice_dpll_sw_pin_notify_peer() which sends a change notification for
the paired SW pin. Call it from ice_dpll_pin_sma_direction_set(),
ice_dpll_sma_pin_state_set(), and ice_dpll_ufl_pin_state_set() after
pf->dplls.lock is released. Use __dpll_pin_change_ntf() because
dpll_lock is still held by the dpll netlink layer (dpll_pin_pre_doit).

Fixes: 2dd5d03c77e2 ("ice: redesign dpll sma/u.fl pins control")
Signed-off-by: Petr Oros <poros@redhat.com>
Tested-by: Alexander Nowlin <alexander.nowlin@intel.com>
Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20260427-jk-iwl-net-petr-oros-fixes-v1-11-cdcb48303fd8@intel.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Petr Oros and committed by
Paolo Abeni 9e5dead1 1a41b58f

+32
+32
drivers/net/ethernet/intel/ice/ice_dpll.c
··· 1155 1155 } 1156 1156 1157 1157 /** 1158 + * ice_dpll_sw_pin_notify_peer - notify the paired SW pin after a state change 1159 + * @d: pointer to dplls struct 1160 + * @changed: the SW pin that was explicitly changed (already notified by dpll core) 1161 + * 1162 + * SMA and U.FL pins share physical signal paths in pairs (SMA1/U.FL1 and 1163 + * SMA2/U.FL2). When one pin's routing changes via the PCA9575 GPIO 1164 + * expander, the paired pin's state may also change. Send a change 1165 + * notification for the peer pin so userspace consumers monitoring the 1166 + * peer via dpll netlink learn about the update. 1167 + * 1168 + * Context: Called from dpll_pin_ops callbacks after pf->dplls.lock is 1169 + * released. Uses __dpll_pin_change_ntf() because dpll_lock is 1170 + * still held by the dpll netlink layer. 1171 + */ 1172 + static void ice_dpll_sw_pin_notify_peer(struct ice_dplls *d, 1173 + struct ice_dpll_pin *changed) 1174 + { 1175 + struct ice_dpll_pin *peer; 1176 + 1177 + peer = (changed >= d->sma && changed < d->sma + ICE_DPLL_PIN_SW_NUM) ? 1178 + &d->ufl[changed->idx] : &d->sma[changed->idx]; 1179 + if (peer->pin) 1180 + __dpll_pin_change_ntf(peer->pin); 1181 + } 1182 + 1183 + /** 1158 1184 * ice_dpll_sma_direction_set - set direction of SMA pin 1159 1185 * @p: pointer to a pin 1160 1186 * @direction: requested direction of the pin ··· 1370 1344 1371 1345 unlock: 1372 1346 mutex_unlock(&pf->dplls.lock); 1347 + if (!ret) 1348 + ice_dpll_sw_pin_notify_peer(&pf->dplls, p); 1373 1349 1374 1350 return ret; 1375 1351 } ··· 1490 1462 1491 1463 unlock: 1492 1464 mutex_unlock(&pf->dplls.lock); 1465 + if (!ret) 1466 + ice_dpll_sw_pin_notify_peer(&pf->dplls, sma); 1493 1467 1494 1468 return ret; 1495 1469 } ··· 1687 1657 mutex_lock(&pf->dplls.lock); 1688 1658 ret = ice_dpll_sma_direction_set(p, direction, extack); 1689 1659 mutex_unlock(&pf->dplls.lock); 1660 + if (!ret) 1661 + ice_dpll_sw_pin_notify_peer(&pf->dplls, p); 1690 1662 1691 1663 return ret; 1692 1664 }