tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

crypto: drivers - Drop sign/verify operations

The drivers aspeed-acry.c, hpre_crypto.c and jh7110-rsa.c purport to
implement sign/verify operations for raw (unpadded) "rsa".

But there is no such thing as message digests generally need to be
padded according to a predefined scheme (such as PSS or PKCS#1) to
match the size of the usually much larger RSA keys.

The bogus sign/verify operations defined by these drivers are never
called but block removal of sign/verify from akcipher_alg. Drop them.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Lukas Wunner and committed by
Herbert Xu a16a17d3 5b553e06

-6
-2
drivers/crypto/aspeed/aspeed-acry.c
··· 601 601 .akcipher.base = { 602 602 .encrypt = aspeed_acry_rsa_enc, 603 603 .decrypt = aspeed_acry_rsa_dec, 604 - .sign = aspeed_acry_rsa_dec, 605 - .verify = aspeed_acry_rsa_enc, 606 604 .set_pub_key = aspeed_acry_rsa_set_pub_key, 607 605 .set_priv_key = aspeed_acry_rsa_set_priv_key, 608 606 .max_size = aspeed_acry_rsa_max_size,
-2
drivers/crypto/hisilicon/hpre/hpre_crypto.c
··· 2006 2006 } 2007 2007 2008 2008 static struct akcipher_alg rsa = { 2009 - .sign = hpre_rsa_dec, 2010 - .verify = hpre_rsa_enc, 2011 2009 .encrypt = hpre_rsa_enc, 2012 2010 .decrypt = hpre_rsa_dec, 2013 2011 .set_pub_key = hpre_rsa_setpubkey,
-2
drivers/crypto/starfive/jh7110-rsa.c
··· 565 565 static struct akcipher_alg starfive_rsa = { 566 566 .encrypt = starfive_rsa_enc, 567 567 .decrypt = starfive_rsa_dec, 568 - .sign = starfive_rsa_dec, 569 - .verify = starfive_rsa_enc, 570 568 .set_pub_key = starfive_rsa_set_pub_key, 571 569 .set_priv_key = starfive_rsa_set_priv_key, 572 570 .max_size = starfive_rsa_max_size,