Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

watchdog: sbsa: Update the W_IIDR Implementer bit mask to 0xFFF

The implementer mask defined in the driver [1] captures bits 0-10,
whereas section C.4.2 of BSA specification [2] indicates that bits
0-11 of the W_IIDR register represent the implementer JEP106 code.
Update the SBSA_GWDT_IMPL_MASK corresponding to bits 0-11, while
at it update SBSA_GWDT_VERSION_MASK mask to use GENMASK.

[1] #define SBSA_GWDT_IMPL_MASK 0x7FF

[2] Implementer, bits [11:0]
Contains the JEP106 code of the company that implemented the
Generic Watchdog:
Bits[11:8] The JEP106 continuation code of the implementer.
Bit[7] Always 0
Bits [6:0] The JEP106 identity code of the implementer.

Signed-off-by: Naina Mehta <naina.mehta@oss.qualcomm.com>
Acked-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

authored by

Naina Mehta and committed by
Wim Van Sebroeck
a1a548c5 b0fd1f58

+2 -2
+2 -2
drivers/watchdog/sbsa_gwdt.c
··· 72 72 #define SBSA_GWDT_WCS_WS0 BIT(1) 73 73 #define SBSA_GWDT_WCS_WS1 BIT(2) 74 74 75 - #define SBSA_GWDT_VERSION_MASK 0xF 75 + #define SBSA_GWDT_VERSION_MASK GENMASK(3, 0) 76 76 #define SBSA_GWDT_VERSION_SHIFT 16 77 77 78 - #define SBSA_GWDT_IMPL_MASK 0x7FF 78 + #define SBSA_GWDT_IMPL_MASK GENMASK(11, 0) 79 79 #define SBSA_GWDT_IMPL_SHIFT 0 80 80 #define SBSA_GWDT_IMPL_MEDIATEK 0x426 81 81