Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
io_uring/register: use atomic_read/write for sq_flags migration
A previous commit changed all of the migration from the old to the new
ring for resizing to use READ/WRITE_ONCE. However, ->sq_flags is an
atomic_t, and while most archs won't complain on this, some will indeed
flag this:
io_uring/register.c:554:9: sparse: sparse: cast to non-scalar
io_uring/register.c:554:9: sparse: sparse: cast from non-scalar
Just use atomic_set/atomic_read for handling this case.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501242000.A2sKqaCL-lkp@intel.com/
Fixes: 2c5aae129f42 ("io_uring/register: document io_register_resize_rings() shared mem usage")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
+1
-1
+1
-1
io_uring/register.c
+1
-1
io_uring/register.c
···
552
552
ctx->cqe_cached = ctx->cqe_sentinel = NULL;
553
553
554
554
WRITE_ONCE(n.rings->sq_dropped, READ_ONCE(o.rings->sq_dropped));
555
-
WRITE_ONCE(n.rings->sq_flags, READ_ONCE(o.rings->sq_flags));
555
+
atomic_set(&n.rings->sq_flags, atomic_read(&o.rings->sq_flags));
556
556
WRITE_ONCE(n.rings->cq_flags, READ_ONCE(o.rings->cq_flags));
557
557
WRITE_ONCE(n.rings->cq_overflow, READ_ONCE(o.rings->cq_overflow));
558
558