Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
ASoC: cs35l56: More KUnit tests for speaker ID
Merge series from Richard Fitzgerald <rf@opensource.cirrus.com>:
The first 3 patches in this series add some more KUnit testing for
fetching speaker ID and combining it with the system name to create
part of the qualifier for a firmware filename.
Patch #4 enables GPIOLIB in KUnit 'alltests' builds. This can be taken
separately from the first 3 patches.
The GPIO tests will skip if GPIOLIB is not enabled, but obviously it
would be ideal for 'kunit.py --alltests' runs to include these new
test cases.
+325
-1
+2
sound/soc/codecs/cs-amp-lib.c
+2
sound/soc/codecs/cs-amp-lib.c
+80
sound/soc/codecs/cs35l56-test.c
+80
sound/soc/codecs/cs35l56-test.c
···
74
74
return ERR_PTR(-ENOENT);
75
75
}
76
76
77
+
static void cs35l56_test_system_name_from_ssid(struct kunit *test)
78
+
{
79
+
struct cs35l56_test_priv *priv = test->priv;
80
+
struct cs35l56_private *cs35l56 = priv->cs35l56_priv;
81
+
82
+
cs35l56->speaker_id = -1;
83
+
snd_soc_card_set_pci_ssid(cs35l56->component->card, 0x12b4, 0xa7c8);
84
+
85
+
KUNIT_EXPECT_EQ(test, cs35l56_get_firmware_uid(cs35l56), 0);
86
+
KUNIT_EXPECT_EQ(test, cs35l56_set_fw_name(cs35l56->component), 0);
87
+
KUNIT_EXPECT_STREQ(test, cs35l56->dsp.system_name, "12b4a7c8");
88
+
}
89
+
90
+
static void cs35l56_test_system_name_from_ssid_and_spkid(struct kunit *test)
91
+
{
92
+
struct cs35l56_test_priv *priv = test->priv;
93
+
struct cs35l56_private *cs35l56 = priv->cs35l56_priv;
94
+
95
+
cs35l56->speaker_id = 1;
96
+
snd_soc_card_set_pci_ssid(cs35l56->component->card, 0x12b4, 0xa7c8);
97
+
98
+
KUNIT_EXPECT_EQ(test, cs35l56_get_firmware_uid(cs35l56), 0);
99
+
KUNIT_EXPECT_EQ(test, cs35l56_set_fw_name(cs35l56->component), 0);
100
+
KUNIT_EXPECT_STREQ(test, cs35l56->dsp.system_name, "12b4a7c8-spkid1");
101
+
}
102
+
103
+
static void cs35l56_test_system_name_from_property(struct kunit *test)
104
+
{
105
+
struct cs35l56_test_priv *priv = test->priv;
106
+
struct cs35l56_private *cs35l56 = priv->cs35l56_priv;
107
+
const struct property_entry dev_props[] = {
108
+
PROPERTY_ENTRY_STRING("cirrus,firmware-uid", "acme"),
109
+
{ }
110
+
};
111
+
const struct software_node dev_node = SOFTWARE_NODE("SPK1", dev_props, NULL);
112
+
113
+
cs35l56->speaker_id = -1;
114
+
115
+
KUNIT_ASSERT_EQ(test, device_add_software_node(cs35l56->base.dev, &dev_node), 0);
116
+
KUNIT_ASSERT_EQ(test, 0,
117
+
kunit_add_action_or_reset(test,
118
+
device_remove_software_node_wrapper,
119
+
cs35l56->base.dev));
120
+
121
+
KUNIT_EXPECT_EQ(test, cs35l56_get_firmware_uid(cs35l56), 0);
122
+
KUNIT_EXPECT_EQ(test, cs35l56_set_fw_name(cs35l56->component), 0);
123
+
KUNIT_EXPECT_STREQ(test, cs35l56->dsp.system_name, "acme");
124
+
}
125
+
126
+
static void cs35l56_test_system_name_from_property_and_spkid(struct kunit *test)
127
+
{
128
+
struct cs35l56_test_priv *priv = test->priv;
129
+
struct cs35l56_private *cs35l56 = priv->cs35l56_priv;
130
+
const struct property_entry dev_props[] = {
131
+
PROPERTY_ENTRY_STRING("cirrus,firmware-uid", "acme"),
132
+
{ }
133
+
};
134
+
const struct software_node dev_node = SOFTWARE_NODE("SPK1", dev_props, NULL);
135
+
136
+
cs35l56->speaker_id = 1;
137
+
138
+
KUNIT_ASSERT_EQ(test, device_add_software_node(cs35l56->base.dev, &dev_node), 0);
139
+
KUNIT_ASSERT_EQ(test, 0,
140
+
kunit_add_action_or_reset(test,
141
+
device_remove_software_node_wrapper,
142
+
cs35l56->base.dev));
143
+
144
+
KUNIT_EXPECT_EQ(test, cs35l56_get_firmware_uid(cs35l56), 0);
145
+
KUNIT_EXPECT_EQ(test, cs35l56_set_fw_name(cs35l56->component), 0);
146
+
KUNIT_EXPECT_STREQ(test, cs35l56->dsp.system_name, "acme-spkid1");
147
+
}
148
+
77
149
static void cs35l56_test_l56_b0_suffix_sdw(struct kunit *test)
78
150
{
79
151
struct cs35l56_test_priv *priv = test->priv;
···
668
596
cs35l56_test_type_rev_param_desc);
669
597
670
598
static struct kunit_case cs35l56_test_cases_soundwire[] = {
599
+
KUNIT_CASE(cs35l56_test_system_name_from_ssid),
600
+
KUNIT_CASE(cs35l56_test_system_name_from_ssid_and_spkid),
601
+
KUNIT_CASE(cs35l56_test_system_name_from_property),
602
+
KUNIT_CASE(cs35l56_test_system_name_from_property_and_spkid),
671
603
KUNIT_CASE(cs35l56_test_l56_b0_suffix_sdw),
672
604
KUNIT_CASE_PARAM(cs35l56_test_suffix_sdw, cs35l56_test_type_rev_ex_b0_gen_params),
673
605
KUNIT_CASE_PARAM(cs35l56_test_ssidexv2_suffix_sdw,
···
689
613
};
690
614
691
615
static struct kunit_case cs35l56_test_cases_not_soundwire[] = {
616
+
KUNIT_CASE(cs35l56_test_system_name_from_ssid),
617
+
KUNIT_CASE(cs35l56_test_system_name_from_ssid_and_spkid),
618
+
KUNIT_CASE(cs35l56_test_system_name_from_property),
619
+
KUNIT_CASE(cs35l56_test_system_name_from_property_and_spkid),
692
620
KUNIT_CASE_PARAM(cs35l56_test_suffix_i2cspi, cs35l56_test_type_rev_all_gen_params),
693
621
KUNIT_CASE_PARAM(cs35l56_test_ssidexv2_suffix_i2cspi,
694
622
cs35l56_test_type_rev_all_gen_params),
+2
-1
sound/soc/codecs/cs35l56.c
+2
-1
sound/soc/codecs/cs35l56.c
···
1661
1661
}
1662
1662
EXPORT_SYMBOL_IF_KUNIT(cs35l56_process_xu_properties);
1663
1663
1664
-
static int cs35l56_get_firmware_uid(struct cs35l56_private *cs35l56)
1664
+
VISIBLE_IF_KUNIT int cs35l56_get_firmware_uid(struct cs35l56_private *cs35l56)
1665
1665
{
1666
1666
struct device *dev = cs35l56->base.dev;
1667
1667
const char *prop;
···
1686
1686
1687
1687
return 0;
1688
1688
}
1689
+
EXPORT_SYMBOL_IF_KUNIT(cs35l56_get_firmware_uid);
1689
1690
1690
1691
/*
1691
1692
* Some SoundWire laptops have a spk-id-gpios property but it points to
+1
sound/soc/codecs/cs35l56.h
+1
sound/soc/codecs/cs35l56.h
···
78
78
int cs35l56_set_fw_suffix(struct cs35l56_private *cs35l56);
79
79
int cs35l56_set_fw_name(struct snd_soc_component *component);
80
80
int cs35l56_process_xu_properties(struct cs35l56_private *cs35l56);
81
+
int cs35l56_get_firmware_uid(struct cs35l56_private *cs35l56);
81
82
#endif
82
83
83
84
#endif /* ifndef CS35L56_H */