tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

selftests: bonding: do not test arp/ns target with mode balance-alb/tlb

The prio_arp/ns tests hard code the mode to active-backup. At the same
time, The balance-alb/tlb modes do not support arp/ns target. So remove
the prio_arp/ns tests from the loop and only test active-backup mode.

Fixes: 481b56e0391e ("selftests: bonding: re-format bond option tests")
Reported-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Closes: https://lore.kernel.org/netdev/17415.1705965957@famine/
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Link: https://lore.kernel.org/r/20240123075917.1576360-1-liuhangbin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Hangbin Liu and committed by
Paolo Abeni a2933a87 a717932d

+4 -4
+4 -4
tools/testing/selftests/drivers/net/bonding/bond_options.sh
··· 162 162 local mode=$1 163 163 164 164 for primary_reselect in 0 1 2; do 165 - prio_test "mode active-backup arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect" 165 + prio_test "mode $mode arp_interval 100 arp_ip_target ${g_ip4} primary eth1 primary_reselect $primary_reselect" 166 166 log_test "prio" "$mode arp_ip_target primary_reselect $primary_reselect" 167 167 done 168 168 } ··· 178 178 fi 179 179 180 180 for primary_reselect in 0 1 2; do 181 - prio_test "mode active-backup arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect" 181 + prio_test "mode $mode arp_interval 100 ns_ip6_target ${g_ip6} primary eth1 primary_reselect $primary_reselect" 182 182 log_test "prio" "$mode ns_ip6_target primary_reselect $primary_reselect" 183 183 done 184 184 } ··· 194 194 195 195 for mode in $modes; do 196 196 prio_miimon $mode 197 - prio_arp $mode 198 - prio_ns $mode 199 197 done 198 + prio_arp "active-backup" 199 + prio_ns "active-backup" 200 200 } 201 201 202 202 arp_validate_test()