tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

selftests/bpf: Fix resource leak in serial_test_wq on attach failure

When wq__attach() fails, serial_test_wq() returns early without calling
wq__destroy(), leaking the skeleton resources allocated by
wq__open_and_load(). This causes ASAN leak reports in selftests runs.

Fix this by jumping to a common clean_up label that calls wq__destroy()
on all exit paths after successful open_and_load.

Note that the early return after wq__open_and_load() failure is correct
and doesn't need fixing, since that function returns NULL on failure
(after internally cleaning up any partial allocations).

Fixes: 8290dba51910 ("selftests/bpf: wq: add bpf_wq_start() checks")
Signed-off-by: Kery Qi <qikeyu2017@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/bpf/20260121094114.1801-3-qikeyu2017@gmail.com

authored by

Kery Qi and committed by
Andrii Nakryiko a32ae265 26ad5d6e

+3 -2
+3 -2
tools/testing/selftests/bpf/prog_tests/wq.c
··· 16 16 /* re-run the success test to check if the timer was actually executed */ 17 17 18 18 wq_skel = wq__open_and_load(); 19 - if (!ASSERT_OK_PTR(wq_skel, "wq_skel_load")) 19 + if (!ASSERT_OK_PTR(wq_skel, "wq__open_and_load")) 20 20 return; 21 21 22 22 err = wq__attach(wq_skel); 23 23 if (!ASSERT_OK(err, "wq_attach")) 24 - return; 24 + goto clean_up; 25 25 26 26 prog_fd = bpf_program__fd(wq_skel->progs.test_syscall_array_sleepable); 27 27 err = bpf_prog_test_run_opts(prog_fd, &topts); ··· 31 31 usleep(50); /* 10 usecs should be enough, but give it extra */ 32 32 33 33 ASSERT_EQ(wq_skel->bss->ok_sleepable, (1 << 1), "ok_sleepable"); 34 + clean_up: 34 35 wq__destroy(wq_skel); 35 36 } 36 37