Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

kernel/kexec: fix IMA when allocation happens in CMA area

*** Bug description ***

When I tested kexec with the latest kernel, I ran into the following warning:

[ 40.712410] ------------[ cut here ]------------
[ 40.712576] WARNING: CPU: 2 PID: 1562 at kernel/kexec_core.c:1001 kimage_map_segment+0x144/0x198
[...]
[ 40.816047] Call trace:
[ 40.818498] kimage_map_segment+0x144/0x198 (P)
[ 40.823221] ima_kexec_post_load+0x58/0xc0
[ 40.827246] __do_sys_kexec_file_load+0x29c/0x368
[...]
[ 40.855423] ---[ end trace 0000000000000000 ]---

*** How to reproduce ***

This bug is only triggered when the kexec target address is allocated in
the CMA area. If no CMA area is reserved in the kernel, use the "cma="
option in the kernel command line to reserve one.

*** Root cause ***
The commit 07d24902977e ("kexec: enable CMA based contiguous
allocation") allocates the kexec target address directly on the CMA area
to avoid copying during the jump. In this case, there is no IND_SOURCE
for the kexec segment. But the current implementation of
kimage_map_segment() assumes that IND_SOURCE pages exist and map them
into a contiguous virtual address by vmap().

*** Solution ***
If IMA segment is allocated in the CMA area, use its page_address()
directly.

Link: https://lkml.kernel.org/r/20251216014852.8737-2-piliu@redhat.com
Fixes: 07d24902977e ("kexec: enable CMA based contiguous allocation")
Signed-off-by: Pingfan Liu <piliu@redhat.com>
Acked-by: Baoquan He <bhe@redhat.com>
Cc: Alexander Graf <graf@amazon.com>
Cc: Steven Chen <chenste@linux.microsoft.com>
Cc: Mimi Zohar <zohar@linux.ibm.com>
Cc: Roberto Sassu <roberto.sassu@huawei.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Pingfan Liu and committed by
Andrew Morton
a3785ae5 fe55ea85

+7 -2
+7 -2
kernel/kexec_core.c
··· 960 960 kimage_entry_t *ptr, entry; 961 961 struct page **src_pages; 962 962 unsigned int npages; 963 + struct page *cma; 963 964 void *vaddr = NULL; 964 965 int i; 966 + 967 + cma = image->segment_cma[idx]; 968 + if (cma) 969 + return page_address(cma); 965 970 966 971 addr = image->segment[idx].mem; 967 972 size = image->segment[idx].memsz; 968 973 eaddr = addr + size; 969 - 970 974 /* 971 975 * Collect the source pages and map them in a contiguous VA range. 972 976 */ ··· 1011 1007 1012 1008 void kimage_unmap_segment(void *segment_buffer) 1013 1009 { 1014 - vunmap(segment_buffer); 1010 + if (is_vmalloc_addr(segment_buffer)) 1011 + vunmap(segment_buffer); 1015 1012 } 1016 1013 1017 1014 struct kexec_load_limit {