Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
rust: syn: remove `unicode-ident` dependency
The `syn` crate depends on the `unicode-ident` crate to determine whether
characters have the XID_Start or XID_Continue properties according to
Unicode Standard Annex #31.
However, we only need ASCII identifiers in the kernel, thus we can
simplify the check and remove completely that dependency.
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Gary Guo <gary@garyguo.net>
Tested-by: Gary Guo <gary@garyguo.net>
Tested-by: Jesung Yang <y.j3ms.n@gmail.com>
Link: https://patch.msgid.link/20251124151837.2184382-18-ojeda@kernel.org
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
+2
-2
+2
-2
rust/syn/ident.rs
+2
-2
rust/syn/ident.rs
···
39
39
pub(crate) fn xid_ok(symbol: &str) -> bool {
40
40
let mut chars = symbol.chars();
41
41
let first = chars.next().unwrap();
42
-
if !(first == '_' || unicode_ident::is_xid_start(first)) {
42
+
if !(first == '_' || first.is_ascii_alphabetic()) {
43
43
return false;
44
44
}
45
45
for ch in chars {
46
-
if !unicode_ident::is_xid_continue(ch) {
46
+
if !(ch == '_' || ch.is_ascii_alphanumeric()) {
47
47
return false;
48
48
}
49
49
}