Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: dsa: dsa_loop: use int type to store negative error codes

Change the 'ret' variable in dsa_loop_init() from unsigned int to int, as
it needs to store either negative error codes or zero returned by
mdio_driver_register().

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but can be confusing. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://patch.msgid.link/20250903123404.395946-1-rongqianfeng@vivo.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Qianfeng Rong and committed by
Jakub Kicinski
a50e7864 3cd4c4f3

+2 -1
+2 -1
drivers/net/dsa/dsa_loop.c
··· 399 399 .speed = SPEED_100, 400 400 .duplex = DUPLEX_FULL, 401 401 }; 402 - unsigned int i, ret; 402 + unsigned int i; 403 + int ret; 403 404 404 405 for (i = 0; i < NUM_FIXED_PHYS; i++) 405 406 phydevs[i] = fixed_phy_register(&status, NULL);