Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

iio: magnetometer: Remove IRQF_ONESHOT

Passing IRQF_ONESHOT ensures that the interrupt source is masked until
the secondary (threaded) handler is done. If only a primary handler is
used then the flag makes no sense because the interrupt can not fire
(again) while its handler is running.
The flag also disallows force-threading of the primary handler and the
irq-core will warn about this.
The force-threading functionality is required on PREEMPT_RT because the
handler is using locks with can sleep on PREEMPT_RT.

Remove IRQF_ONESHOT from irqflags.

Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Sebastian Andrzej Siewior and committed by
Jonathan Cameron
a54e9440 ac9fabd5

+1 -1
+1 -1
drivers/iio/magnetometer/ak8975.c
··· 581 581 irq = gpiod_to_irq(data->eoc_gpiod); 582 582 583 583 rc = devm_request_irq(&client->dev, irq, ak8975_irq_handler, 584 - IRQF_TRIGGER_RISING | IRQF_ONESHOT, 584 + IRQF_TRIGGER_RISING, 585 585 dev_name(&client->dev), data); 586 586 if (rc < 0) { 587 587 dev_err(&client->dev, "irq %d request failed: %d\n", irq, rc);