tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

minmax.h: use BUILD_BUG_ON_MSG() for the lo < hi test in clamp()

Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity check
of the bounds in clamp(). Gives better error coverage and one less
expansion of the arguments.

Link: https://lkml.kernel.org/r/34d53778977747f19cce2abb287bb3e6@AcuMS.aculab.com
Signed-off-by: David Laight <david.laight@aculab.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Arnd Bergmann <arnd@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Mateusz Guzik <mjguzik@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

David Laight and committed by
Andrew Morton a5743f32 b280bb27

+1 -2
+1 -2
include/linux/minmax.h
··· 106 106 __auto_type uval = (val); \ 107 107 __auto_type ulo = (lo); \ 108 108 __auto_type uhi = (hi); \ 109 - static_assert(__builtin_choose_expr(__is_constexpr((lo) > (hi)), \ 110 - (lo) <= (hi), true), \ 109 + BUILD_BUG_ON_MSG(statically_true(ulo > uhi), \ 111 110 "clamp() low limit " #lo " greater than high limit " #hi); \ 112 111 BUILD_BUG_ON_MSG(!__types_ok3(uval, ulo, uhi), \ 113 112 "clamp("#val", "#lo", "#hi") signedness error"); \