tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

qlcnic: make the array random_data static const, makes object smaller

Don't populate the array random_data on the stack but instead it
static const. Makes the object code smaller by 66 bytes.

Before:
text data bss dec hex filename
52895 10976 0 63871 f97f ../qlogic/qlcnic/qlcnic_ethtool.o

After:
text data bss dec hex filename
52701 11104 0 63805 f93d ../qlogic//qlcnic/qlcnic_ethtool.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210801151659.146113-1-colin.king@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Colin Ian King and committed by
Jakub Kicinski a6afdb04 628fe1ce

+1 -1
+1 -1
drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c
··· 1021 1021 1022 1022 static void qlcnic_create_loopback_buff(unsigned char *data, u8 mac[]) 1023 1023 { 1024 - unsigned char random_data[] = {0xa8, 0x06, 0x45, 0x00}; 1024 + static const unsigned char random_data[] = {0xa8, 0x06, 0x45, 0x00}; 1025 1025 1026 1026 memset(data, 0x4e, QLCNIC_ILB_PKT_SIZE); 1027 1027