tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

cpufreq: s5pv210: Simplify with scoped for each OF child loop

Use scoped for-each loop when iterating over device nodes to make code a
bit simpler. Note that there is another part of code using "np"
variable, so scoped loop should not shadow it.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260109-of-for-each-compatible-scoped-v3-11-c22fa2c0749a@oss.qualcomm.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

authored by

Krzysztof Kozlowski and committed by
Rob Herring (Arm) a91b99fa 69c8cbb4

+4 -6
+4 -6
drivers/cpufreq/s5pv210-cpufreq.c
··· 629 629 goto err_clock; 630 630 } 631 631 632 - for_each_compatible_node(np, NULL, "samsung,s5pv210-dmc") { 633 - id = of_alias_get_id(np, "dmc"); 632 + for_each_compatible_node_scoped(dmc, NULL, "samsung,s5pv210-dmc") { 633 + id = of_alias_get_id(dmc, "dmc"); 634 634 if (id < 0 || id >= ARRAY_SIZE(dmc_base)) { 635 - dev_err(dev, "failed to get alias of dmc node '%pOFn'\n", np); 636 - of_node_put(np); 635 + dev_err(dev, "failed to get alias of dmc node '%pOFn'\n", dmc); 637 636 result = id; 638 637 goto err_clk_base; 639 638 } 640 639 641 - dmc_base[id] = of_iomap(np, 0); 640 + dmc_base[id] = of_iomap(dmc, 0); 642 641 if (!dmc_base[id]) { 643 642 dev_err(dev, "failed to map dmc%d registers\n", id); 644 - of_node_put(np); 645 643 result = -EFAULT; 646 644 goto err_dmc; 647 645 }