Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
HID: logitech-dj: Standardise hid_report_enum variable nomenclature
Since we will need to differentiate between the two report_enum types
soon, let's unify the naming conventions now to save confusion and/or
unnecessary/unrelated changes in upcoming commits.
{input,output}_report_enum is used in other places to let's conform.
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
authored by
Lee Jones
and committed by
Jiri Kosina
a940aee1
e606d832
+6
-6
+6
-6
drivers/hid/hid-logitech-dj.c
+6
-6
drivers/hid/hid-logitech-dj.c
···
1858
1858
static int logi_dj_probe(struct hid_device *hdev,
1859
1859
const struct hid_device_id *id)
1860
1860
{
1861
-
struct hid_report_enum *rep_enum;
1861
+
struct hid_report_enum *input_report_enum;
1862
1862
struct hid_report *rep;
1863
1863
struct dj_receiver_dev *djrcv_dev;
1864
1864
struct usb_interface *intf;
···
1903
1903
}
1904
1904
}
1905
1905
1906
-
rep_enum = &hdev->report_enum[HID_INPUT_REPORT];
1906
+
input_report_enum = &hdev->report_enum[HID_INPUT_REPORT];
1907
1907
1908
1908
/* no input reports, bail out */
1909
-
if (list_empty(&rep_enum->report_list))
1909
+
if (list_empty(&input_report_enum->report_list))
1910
1910
return -ENODEV;
1911
1911
1912
1912
/*
···
1914
1914
* Note: we should theoretically check for HID++ and DJ
1915
1915
* collections, but this will do.
1916
1916
*/
1917
-
list_for_each_entry(rep, &rep_enum->report_list, list) {
1917
+
list_for_each_entry(rep, &input_report_enum->report_list, list) {
1918
1918
if (rep->application == 0xff000001)
1919
1919
has_hidpp = true;
1920
1920
}
···
1927
1927
return -ENODEV;
1928
1928
1929
1929
/* get the current application attached to the node */
1930
-
rep = list_first_entry(&rep_enum->report_list, struct hid_report, list);
1930
+
rep = list_first_entry(&input_report_enum->report_list, struct hid_report, list);
1931
1931
djrcv_dev = dj_get_receiver_dev(hdev, id->driver_data,
1932
1932
rep->application, has_hidpp);
1933
1933
if (!djrcv_dev) {
···
1935
1935
return -ENOMEM;
1936
1936
}
1937
1937
1938
-
if (!rep_enum->numbered)
1938
+
if (!input_report_enum->numbered)
1939
1939
djrcv_dev->unnumbered_application = rep->application;
1940
1940
1941
1941
/* Starts the usb device and connects to upper interfaces hiddev and