sfi: table irq 0xFF means 'no interrupt'

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

According to the SFI specification irq number 0xFF means device has no
interrupt or interrupt attached via GPIO.

Currently, we don't handle this special case and set irq field in
*_board_info structs to 255. It leads to confusion in some drivers.
Accelerometer driver tries to register interrupt 255, fails and prints
"Cannot get IRQ" to dmesg.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Kirill A. Shutemov and committed by

Linus Torvalds 15 years ago a94cc4e6 1e8d4e8b

+3 -1

1 changed file

expand all

arch

x86

platform

mrst

mrst.c

+3 -1

arch/x86/platform/mrst/mrst.c

··· 689 689 irq_attr.trigger = 1; 690 690 irq_attr.polarity = 1; 691 691 io_apic_set_pci_routing(NULL, pentry->irq, &irq_attr); 692 - } 692 + } else 693 + pentry->irq = 0; /* No irq */ 694 + 693 695 switch (pentry->type) { 694 696 case SFI_DEV_TYPE_IPC: 695 697 /* ID as IRQ is a hack that will go away */

Configure Feed

Configure Feed