Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

lib/cpumask: deprecate nr_cpumask_bits

Cpumask code is written in assumption that when CONFIG_CPUMASK_OFFSTACK
is enabled, all cpumasks have boot-time defined size, otherwise the size
is always NR_CPUS.

The latter is wrong because the number of possible cpus is always
calculated on boot, and it may be less than NR_CPUS.

On my 4-cpu arm64 VM the nr_cpu_ids is 4, as expected, and nr_cpumask_bits
is 256, which corresponds to NR_CPUS. This not only leads to useless
traversing of cpumask bits greater than 4, this also makes some cpumask
routines fail.

For example, cpumask_full(0b1111000..000) would erroneously return false
in the example above because tail bits in the mask are all unset.

This patch deprecates nr_cpumask_bits and wires it to nr_cpu_ids
unconditionally, so that cpumask routines will not waste time traversing
unused part of cpu masks. It also fixes cpumask_full() and similar
routines.

As a side effect, because now a length of cpumasks is defined at run-time
even if CPUMASK_OFFSTACK is disabled, compiler can't optimize corresponding
functions.

It increases kernel size by ~2.5KB if OFFSTACK is off. This is addressed in
the following patch.

Signed-off-by: Yury Norov <yury.norov@gmail.com>

+1 -6
+1 -6
include/linux/cpumask.h
··· 46 46 } 47 47 #endif 48 48 49 - #ifdef CONFIG_CPUMASK_OFFSTACK 50 - /* Assuming NR_CPUS is huge, a runtime limit is more efficient. Also, 51 - * not all bits may be allocated. */ 49 + /* Deprecated. Always use nr_cpu_ids. */ 52 50 #define nr_cpumask_bits nr_cpu_ids 53 - #else 54 - #define nr_cpumask_bits ((unsigned int)NR_CPUS) 55 - #endif 56 51 57 52 /* 58 53 * The following particular system cpumasks and operations manage