Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/damon/core: implement damon_initialized() function

Patch series "mm/damon: define and use DAMON initialization check
function".

DAMON is initialized in subsystem initialization time, by damon_init().
If DAMON API functions are called before the initialization, the
system could crash. Actually such issues happened and were fixed [1]
in the past. For the fix, DAMON API callers have updated to check if
DAMON is initialized or not, using their own hacks. The hacks are
unnecessarily duplicated on every DAMON API callers and therefore it
would be difficult to reliably maintain in the long term.

Make it reliable and easy to maintain. For this, implement a new DAMON
core layer API function that returns if DAMON is successfully
initialized. If it returns true, it means DAMON API functions are safe
to be used. After the introduction of the new API, update DAMON API
callers to use the new function instead of their own hacks.


This patch (of 7):

If DAMON is tried to be used when it is not yet successfully initialized,
the caller could be crashed. DAMON core layer is not providing a reliable
way to see if it is successfully initialized and therefore ready to be
used, though. As a result, DAMON API callers are implementing their own
hacks to see it. The hacks simply assume DAMON should be ready on module
init time. It is not reliable as DAMON initialization can indeed fail if
KMEM_CACHE() fails, and difficult to maintain as those are duplicates.
Implement a core layer API function for better reliability and
maintainability to replace the hacks with followup commits.

Link: https://lkml.kernel.org/r/20250916033511.116366-2-sj@kernel.org
Link: https://lkml.kernel.org/r/20250916033511.116366-2-sj@kernel.org
Link: https://lore.kernel.org/20250909022238.2989-1-sj@kernel.org [1]
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

SeongJae Park and committed by
Andrew Morton
ab152db3 9044cbe5

+11
+1
include/linux/damon.h
··· 938 938 } 939 939 940 940 941 + bool damon_initialized(void); 941 942 int damon_start(struct damon_ctx **ctxs, int nr_ctxs, bool exclusive); 942 943 int damon_stop(struct damon_ctx **ctxs, int nr_ctxs); 943 944 bool damon_is_running(struct damon_ctx *ctx);
+10
mm/damon/core.c
··· 2863 2863 r->nr_accesses++; 2864 2864 } 2865 2865 2866 + /** 2867 + * damon_initialized() - Return if DAMON is ready to be used. 2868 + * 2869 + * Return: true if DAMON is ready to be used, false otherwise. 2870 + */ 2871 + bool damon_initialized(void) 2872 + { 2873 + return damon_region_cache != NULL; 2874 + } 2875 + 2866 2876 static int __init damon_init(void) 2867 2877 { 2868 2878 damon_region_cache = KMEM_CACHE(damon_region, 0);