tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/msm/dpu: dpu_hw_pingpong.h: fix all kernel-doc warnings

Correct or add kernel-doc comments to eliminate all warnings:

Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:36 Cannot find
identifier on line: *
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:46 Incorrect use
of kernel-doc format: * enables vysnc generation and sets up init value of
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:53 Incorrect use
of kernel-doc format: * disables tear check block
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:58 Incorrect use
of kernel-doc format: * read, modify, write to either set or clear
listening to external TE
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:65 Incorrect use
of kernel-doc format: * Obtain current vertical line counter
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:70 Incorrect use
of kernel-doc format: * Disable autorefresh if enabled
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:75 Incorrect use
of kernel-doc format: * Setup dither matix for pingpong block
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:80 Incorrect use
of kernel-doc format: * Enable DSC
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:85 Incorrect use
of kernel-doc format: * Disable DSC
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:90 Incorrect use
of kernel-doc format: * Setup DSC
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:93 struct member
'connect_external_te' not described in 'dpu_hw_pingpong_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:93 struct member
'disable_autorefresh' not described in 'dpu_hw_pingpong_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:93 struct member
'enable_dsc' not described in 'dpu_hw_pingpong_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:93 struct member
'disable_dsc' not described in 'dpu_hw_pingpong_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h:93 struct member
'setup_dsc' not described in 'dpu_hw_pingpong_ops'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/695659/
Link: https://lore.kernel.org/r/20251219184638.1813181-12-rdunlap@infradead.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

authored by

Randy Dunlap and committed by
Dmitry Baryshkov abc287a7 847c12be

+10 -10
+10 -10
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h
··· 34 34 }; 35 35 36 36 /** 37 - * 38 37 * struct dpu_hw_pingpong_ops : Interface to the pingpong Hw driver functions 39 38 * Assumption is these functions will be called after clocks are enabled 40 39 * @enable_tearcheck: program and enable tear check block ··· 43 44 */ 44 45 struct dpu_hw_pingpong_ops { 45 46 /** 46 - * enables vysnc generation and sets up init value of 47 + * @enable_tearcheck: enables vysnc generation and sets up init value of 47 48 * read pointer and programs the tear check cofiguration 48 49 */ 49 50 int (*enable_tearcheck)(struct dpu_hw_pingpong *pp, 50 51 struct dpu_hw_tear_check *cfg); 51 52 52 53 /** 53 - * disables tear check block 54 + * @disable_tearcheck: disables tear check block 54 55 */ 55 56 int (*disable_tearcheck)(struct dpu_hw_pingpong *pp); 56 57 57 58 /** 58 - * read, modify, write to either set or clear listening to external TE 59 + * @connect_external_te: read, modify, write to either set or clear 60 + * listening to external TE 59 61 * @Return: 1 if TE was originally connected, 0 if not, or -ERROR 60 62 */ 61 63 int (*connect_external_te)(struct dpu_hw_pingpong *pp, 62 64 bool enable_external_te); 63 65 64 66 /** 65 - * Obtain current vertical line counter 67 + * @get_line_count: Obtain current vertical line counter 66 68 */ 67 69 u32 (*get_line_count)(struct dpu_hw_pingpong *pp); 68 70 69 71 /** 70 - * Disable autorefresh if enabled 72 + * @disable_autorefresh: Disable autorefresh if enabled 71 73 */ 72 74 void (*disable_autorefresh)(struct dpu_hw_pingpong *pp, uint32_t encoder_id, u16 vdisplay); 73 75 74 76 /** 75 - * Setup dither matix for pingpong block 77 + * @setup_dither: Setup dither matix for pingpong block 76 78 */ 77 79 void (*setup_dither)(struct dpu_hw_pingpong *pp, 78 80 struct dpu_hw_dither_cfg *cfg); 79 81 /** 80 - * Enable DSC 82 + * @enable_dsc: Enable DSC 81 83 */ 82 84 int (*enable_dsc)(struct dpu_hw_pingpong *pp); 83 85 84 86 /** 85 - * Disable DSC 87 + * @disable_dsc: Disable DSC 86 88 */ 87 89 void (*disable_dsc)(struct dpu_hw_pingpong *pp); 88 90 89 91 /** 90 - * Setup DSC 92 + * @setup_dsc: Setup DSC 91 93 */ 92 94 int (*setup_dsc)(struct dpu_hw_pingpong *pp); 93 95 };