tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

[PATCH] Avoid namespace pollution in <asm/param.h>

In commit 3D59121003721a8fad11ee72e646fd9d3076b5679c, the x86 and x86-64
<asm/param.h> was changed to include <linux/config.h> for the
configurable timer frequency.

However, asm/param.h is sometimes used in userland (it is included
indirectly from <sys/param.h>), so your commit pollutes the userland
namespace with tons of CONFIG_FOO macros. This greatly confuses
software packages (such as BusyBox) which use CONFIG_FOO macros
themselves to control the inclusion of optional features.

After a short exchange, Christoph approved this patch

Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by

Dag-Erling Sm�rgrav and committed by
Linus Torvalds abe842eb f12f4d90

+2 -4
+1 -2
include/asm-i386/param.h
··· 1 - #include <linux/config.h> 2 - 3 1 #ifndef _ASMi386_PARAM_H 4 2 #define _ASMi386_PARAM_H 5 3 6 4 #ifdef __KERNEL__ 5 + # include <linux/config.h> 7 6 # define HZ CONFIG_HZ /* Internal kernel timer frequency */ 8 7 # define USER_HZ 100 /* .. some user interfaces are in "ticks" */ 9 8 # define CLOCKS_PER_SEC (USER_HZ) /* like times() */
+1 -2
include/asm-x86_64/param.h
··· 1 - #include <linux/config.h> 2 - 3 1 #ifndef _ASMx86_64_PARAM_H 4 2 #define _ASMx86_64_PARAM_H 5 3 6 4 #ifdef __KERNEL__ 5 + # include <linux/config.h> 7 6 # define HZ CONFIG_HZ /* Internal kernel timer frequency */ 8 7 # define USER_HZ 100 /* .. some user interfaces are in "ticks */ 9 8 #define CLOCKS_PER_SEC (USER_HZ) /* like times() */