tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

perf report: Support switching data w/ and w/o callchains

The symbol_conf.use_callchain should be reset when switching to new data
file, otherwise report__setup_sample_type() will show an error message
that it enabled callchains but no callchain data. The function also
will turn on the callchains if the data has PERF_SAMPLE_CALLCHAIN so I
think it's ok to reset symbol_conf.use_callchain here.

Link: https://lore.kernel.org/r/20250211060745.294289-2-namhyung@kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Namhyung Kim acda4c20 43c2b613

+5
+5
tools/perf/builtin-report.c
··· 1865 1865 if (ret == K_SWITCH_INPUT_DATA || ret == K_RELOAD) { 1866 1866 perf_session__delete(session); 1867 1867 last_key = K_SWITCH_INPUT_DATA; 1868 + /* 1869 + * To support switching between data with and without callchains. 1870 + * report__setup_sample_type() will update it properly. 1871 + */ 1872 + symbol_conf.use_callchain = false; 1868 1873 goto repeat; 1869 1874 } else 1870 1875 ret = 0;