tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: fs_enet: Fix address space and base types mismatches

CHECK drivers/net/ethernet/freescale/fs_enet/mac-fcc.c
drivers/net/ethernet/freescale/fs_enet/mac-fcc.c:550:9: warning: cast removes address space '__iomem' of expression
drivers/net/ethernet/freescale/fs_enet/mac-fcc.c:550:9: error: subtraction of different types can't work (different address spaces)
CC drivers/net/ethernet/freescale/fs_enet/mii-bitbang.o
CHECK drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c:95:31: warning: incorrect type in argument 1 (different base types)
drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c:95:31: expected unsigned int [noderef] [usertype] __iomem *p
drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c:95:31: got restricted __be32 [noderef] [usertype] __iomem *dat
...
drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c:63:31: warning: incorrect type in argument 1 (different base types)
drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c:63:31: expected unsigned int [noderef] [usertype] __iomem *p
drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c:63:31: got restricted __be32 [noderef] [usertype] __iomem *dir
...

Fix those address space and base type mismatches reported by sparse.

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/25c7965e6aeeb6bbe1b6be5a3c2c7125182fcb02.1691155346.git.christophe.leroy@csgroup.eu
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Christophe Leroy and committed by
Jakub Kicinski ae9e78a9 78d39027

+3 -3
+1 -1
drivers/net/ethernet/freescale/fs_enet/mac-fcc.c
··· 547 547 } 548 548 /* Now update the TBPTR and dirty flag to the current buffer */ 549 549 W32(ep, fen_genfcc.fcc_tbptr, 550 - (uint) (((void *)recheck_bd - fep->ring_base) + 550 + (uint)(((void __iomem *)recheck_bd - fep->ring_base) + 551 551 fep->ring_mem_addr)); 552 552 fep->dirty_tx = recheck_bd; 553 553
+2 -2
drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c
··· 29 29 30 30 struct bb_info { 31 31 struct mdiobb_ctrl ctrl; 32 - __be32 __iomem *dir; 33 - __be32 __iomem *dat; 32 + u32 __iomem *dir; 33 + u32 __iomem *dat; 34 34 u32 mdio_msk; 35 35 u32 mdc_msk; 36 36 };