tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

iio: adc: rzg2l_adc: Use devres helpers to request pre-deasserted reset controls

Starting with commit d872bed85036 ("reset: Add devres helpers to request
pre-deasserted reset controls"), devres helpers are available to simplify
the process of requesting pre-deasserted reset controls. Update the
rzg2l_adc driver to utilize these helpers, reducing complexity in this
way.

Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://patch.msgid.link/20241206111337.726244-4-claudiu.beznea.uj@bp.renesas.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Claudiu Beznea and committed by
Jonathan Cameron b010b104 a34dc289

+4 -31
+4 -31
drivers/iio/adc/rzg2l_adc.c
··· 412 412 pm_runtime_set_suspended(dev->parent); 413 413 } 414 414 415 - static void rzg2l_adc_reset_assert(void *data) 416 - { 417 - reset_control_assert(data); 418 - } 419 - 420 415 static int rzg2l_adc_probe(struct platform_device *pdev) 421 416 { 422 417 struct device *dev = &pdev->dev; ··· 446 451 return dev_err_probe(dev, PTR_ERR(adc->adclk), 447 452 "Failed to get adclk"); 448 453 449 - adc->adrstn = devm_reset_control_get_exclusive(dev, "adrst-n"); 454 + adc->adrstn = devm_reset_control_get_exclusive_deasserted(dev, "adrst-n"); 450 455 if (IS_ERR(adc->adrstn)) 451 456 return dev_err_probe(dev, PTR_ERR(adc->adrstn), 452 - "failed to get adrstn\n"); 457 + "failed to get/deassert adrst-n\n"); 453 458 454 - adc->presetn = devm_reset_control_get_exclusive(dev, "presetn"); 459 + adc->presetn = devm_reset_control_get_exclusive_deasserted(dev, "presetn"); 455 460 if (IS_ERR(adc->presetn)) 456 461 return dev_err_probe(dev, PTR_ERR(adc->presetn), 457 - "failed to get presetn\n"); 458 - 459 - ret = reset_control_deassert(adc->adrstn); 460 - if (ret) 461 - return dev_err_probe(&pdev->dev, ret, 462 - "failed to deassert adrstn pin\n"); 463 - 464 - ret = devm_add_action_or_reset(&pdev->dev, 465 - rzg2l_adc_reset_assert, adc->adrstn); 466 - if (ret) 467 - return dev_err_probe(&pdev->dev, ret, 468 - "failed to register adrstn assert devm action\n"); 469 - 470 - ret = reset_control_deassert(adc->presetn); 471 - if (ret) 472 - return dev_err_probe(&pdev->dev, ret, 473 - "failed to deassert presetn pin\n"); 474 - 475 - ret = devm_add_action_or_reset(&pdev->dev, 476 - rzg2l_adc_reset_assert, adc->presetn); 477 - if (ret) 478 - return dev_err_probe(&pdev->dev, ret, 479 - "failed to register presetn assert devm action\n"); 462 + "failed to get/deassert presetn\n"); 480 463 481 464 ret = rzg2l_adc_hw_init(adc); 482 465 if (ret)