Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/msm/dpu: drop dpu_encoder_phys_ops::atomic_check()
Writeback was the last user of dpu_encoder_phys_ops's atomic_check()
callback. As the code was moved to the dpu_writeback.c, the callback
becomes unused. Drop it now.
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/577528/
Link: https://lore.kernel.org/r/20240208-fd_remove_phys_ops_atomic_mode_set-v4-5-caf5dcd125c0@linaro.org
-19
-15
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
-15
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
···
591
591
struct dpu_global_state *global_state;
592
592
struct drm_framebuffer *fb;
593
593
struct drm_dsc_config *dsc;
594
-
int i = 0;
595
594
int ret = 0;
596
595
597
596
if (!drm_enc || !crtc_state || !conn_state) {
···
610
611
return PTR_ERR(global_state);
611
612
612
613
trace_dpu_enc_atomic_check(DRMID(drm_enc));
613
-
614
-
/* perform atomic check on the first physical encoder (master) */
615
-
for (i = 0; i < dpu_enc->num_phys_encs; i++) {
616
-
struct dpu_encoder_phys *phys = dpu_enc->phys_encs[i];
617
-
618
-
if (phys->ops.atomic_check)
619
-
ret = phys->ops.atomic_check(phys, crtc_state,
620
-
conn_state);
621
-
if (ret) {
622
-
DPU_ERROR_ENC(dpu_enc,
623
-
"mode unsupported, phys idx %d\n", i);
624
-
return ret;
625
-
}
626
-
}
627
614
628
615
dsc = dpu_encoder_get_dsc_config(drm_enc);
629
616
-4
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h
-4
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h
···
71
71
* on split_role and current mode (CMD/VID).
72
72
* @enable: DRM Call. Enable a DRM mode.
73
73
* @disable: DRM Call. Disable mode.
74
-
* @atomic_check: DRM Call. Atomic check new DRM state.
75
74
* @control_vblank_irq Register/Deregister for VBLANK IRQ
76
75
* @wait_for_commit_done: Wait for hardware to have flushed the
77
76
* current pending frames to hardware
···
95
96
bool (*is_master)(struct dpu_encoder_phys *encoder);
96
97
void (*enable)(struct dpu_encoder_phys *encoder);
97
98
void (*disable)(struct dpu_encoder_phys *encoder);
98
-
int (*atomic_check)(struct dpu_encoder_phys *encoder,
99
-
struct drm_crtc_state *crtc_state,
100
-
struct drm_connector_state *conn_state);
101
99
int (*control_vblank_irq)(struct dpu_encoder_phys *enc, bool enable);
102
100
int (*wait_for_commit_done)(struct dpu_encoder_phys *phys_enc);
103
101
int (*wait_for_tx_complete)(struct dpu_encoder_phys *phys_enc);