tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

crash_dump: constify struct configfs_item_operations and configfs_group_operations

'struct configfs_item_operations' and 'configfs_group_operations' are not
modified in this driver.

Constifying these structures moves some data to a read-only section, so
increases overall security, especially when the structure holds some
function pointers.

On a x86_64, with allmodconfig, as an example:
Before:
======
text data bss dec hex filename
16339 11001 384 27724 6c4c kernel/crash_dump_dm_crypt.o

After:
=====
text data bss dec hex filename
16499 10841 384 27724 6c4c kernel/crash_dump_dm_crypt.o

Link: https://lkml.kernel.org/r/d046ee5666d2f6b1a48ca1a222dfbd2f7c44462f.1765735035.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Coiby Xu <coxu@redhat.com>
Tested-by: Coiby Xu <coxu@redhat.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Christophe JAILLET and committed by
Andrew Morton b11052be 03192270

+2 -2
+2 -2
kernel/crash_dump_dm_crypt.c
··· 223 223 key_count--; 224 224 } 225 225 226 - static struct configfs_item_operations config_key_item_ops = { 226 + static const struct configfs_item_operations config_key_item_ops = { 227 227 .release = config_key_release, 228 228 }; 229 229 ··· 298 298 * Note that, since no extra work is required on ->drop_item(), 299 299 * no ->drop_item() is provided. 300 300 */ 301 - static struct configfs_group_operations config_keys_group_ops = { 301 + static const struct configfs_group_operations config_keys_group_ops = { 302 302 .make_item = config_keys_make_item, 303 303 }; 304 304