tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

test_hexdump: use memcpy instead of strncpy

New versions of gcc reasonably warn about the odd pattern of

strncpy(p, q, strlen(q));

which really doesn't make sense: the strncpy() ends up being just a slow
and odd way to write memcpy() in this case.

Apparently there was a patch for this floating around earlier, but it
got lost.

Acked-again-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Linus Torvalds b1286ed7 1ec63573

+1 -1
+1 -1
lib/test_hexdump.c
··· 99 99 const char *q = *result++; 100 100 size_t amount = strlen(q); 101 101 102 - strncpy(p, q, amount); 102 + memcpy(p, q, amount); 103 103 p += amount; 104 104 105 105 *p++ = ' ';