Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
dt-bindings: phy: qcom,qusb2: do not define properties in "if" block
It is more readable to define properties in top-level "properties:" and
restrict them (if needed) per compatible in the "if" block. Defining
properties in "if" block does not work correctly with
additionalProperties:false:
sc7180-trogdor-pazquel-lte-ti.dtb: phy@88e3000: 'qcom,bias-ctrl-value', 'qcom,charge-ctrl-value', 'qcom,hsdisc-trim-value',
'qcom,imp-res-offset-value', 'qcom,preemphasis-level', 'qcom,preemphasis-width' do not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20221224154226.43417-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
authored by
Krzysztof Kozlowski
and committed by
Vinod Koul
b1e96b50
9160fb7c
+79
-69
+79
-69
Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
+79
-69
Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
···
82
82
Phandle to TCSR syscon register region.
83
83
$ref: /schemas/types.yaml#/definitions/phandle
84
84
85
-
if:
86
-
properties:
87
-
compatible:
88
-
contains:
89
-
const: qcom,qusb2-v2-phy
90
-
then:
91
-
properties:
92
-
qcom,imp-res-offset-value:
93
-
description:
94
-
It is a 6 bit value that specifies offset to be
95
-
added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY
96
-
tuning parameter that may vary for different boards of same SOC.
97
-
$ref: /schemas/types.yaml#/definitions/uint32
98
-
minimum: 0
99
-
maximum: 63
100
-
default: 0
85
+
qcom,imp-res-offset-value:
86
+
description:
87
+
It is a 6 bit value that specifies offset to be
88
+
added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY
89
+
tuning parameter that may vary for different boards of same SOC.
90
+
$ref: /schemas/types.yaml#/definitions/uint32
91
+
minimum: 0
92
+
maximum: 63
93
+
default: 0
101
94
102
-
qcom,bias-ctrl-value:
103
-
description:
104
-
It is a 6 bit value that specifies bias-ctrl-value. It is a PHY
105
-
tuning parameter that may vary for different boards of same SOC.
106
-
$ref: /schemas/types.yaml#/definitions/uint32
107
-
minimum: 0
108
-
maximum: 63
109
-
default: 32
95
+
qcom,bias-ctrl-value:
96
+
description:
97
+
It is a 6 bit value that specifies bias-ctrl-value. It is a PHY
98
+
tuning parameter that may vary for different boards of same SOC.
99
+
$ref: /schemas/types.yaml#/definitions/uint32
100
+
minimum: 0
101
+
maximum: 63
102
+
default: 32
110
103
111
-
qcom,charge-ctrl-value:
112
-
description:
113
-
It is a 2 bit value that specifies charge-ctrl-value. It is a PHY
114
-
tuning parameter that may vary for different boards of same SOC.
115
-
$ref: /schemas/types.yaml#/definitions/uint32
116
-
minimum: 0
117
-
maximum: 3
118
-
default: 0
104
+
qcom,charge-ctrl-value:
105
+
description:
106
+
It is a 2 bit value that specifies charge-ctrl-value. It is a PHY
107
+
tuning parameter that may vary for different boards of same SOC.
108
+
$ref: /schemas/types.yaml#/definitions/uint32
109
+
minimum: 0
110
+
maximum: 3
111
+
default: 0
119
112
120
-
qcom,hstx-trim-value:
121
-
description:
122
-
It is a 4 bit value that specifies tuning for HSTX
123
-
output current.
124
-
Possible range is - 15mA to 24mA (stepsize of 600 uA).
125
-
See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.
126
-
$ref: /schemas/types.yaml#/definitions/uint32
127
-
minimum: 0
128
-
maximum: 15
129
-
default: 3
113
+
qcom,hstx-trim-value:
114
+
description:
115
+
It is a 4 bit value that specifies tuning for HSTX
116
+
output current.
117
+
Possible range is - 15mA to 24mA (stepsize of 600 uA).
118
+
See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.
119
+
$ref: /schemas/types.yaml#/definitions/uint32
120
+
minimum: 0
121
+
maximum: 15
122
+
default: 3
130
123
131
-
qcom,preemphasis-level:
132
-
description:
133
-
It is a 2 bit value that specifies pre-emphasis level.
134
-
Possible range is 0 to 15% (stepsize of 5%).
135
-
See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.
136
-
$ref: /schemas/types.yaml#/definitions/uint32
137
-
minimum: 0
138
-
maximum: 3
139
-
default: 2
124
+
qcom,preemphasis-level:
125
+
description:
126
+
It is a 2 bit value that specifies pre-emphasis level.
127
+
Possible range is 0 to 15% (stepsize of 5%).
128
+
See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.
129
+
$ref: /schemas/types.yaml#/definitions/uint32
130
+
minimum: 0
131
+
maximum: 3
132
+
default: 2
140
133
141
-
qcom,preemphasis-width:
142
-
description:
143
-
It is a 1 bit value that specifies how long the HSTX
144
-
pre-emphasis (specified using qcom,preemphasis-level) must be in
145
-
effect. Duration could be half-bit of full-bit.
146
-
See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.
147
-
$ref: /schemas/types.yaml#/definitions/uint32
148
-
minimum: 0
149
-
maximum: 1
150
-
default: 0
134
+
qcom,preemphasis-width:
135
+
description:
136
+
It is a 1 bit value that specifies how long the HSTX
137
+
pre-emphasis (specified using qcom,preemphasis-level) must be in
138
+
effect. Duration could be half-bit of full-bit.
139
+
See dt-bindings/phy/phy-qcom-qusb2.h for applicable values.
140
+
$ref: /schemas/types.yaml#/definitions/uint32
141
+
minimum: 0
142
+
maximum: 1
143
+
default: 0
151
144
152
-
qcom,hsdisc-trim-value:
153
-
description:
154
-
It is a 2 bit value tuning parameter that control disconnect
155
-
threshold and may vary for different boards of same SOC.
156
-
$ref: /schemas/types.yaml#/definitions/uint32
157
-
minimum: 0
158
-
maximum: 3
159
-
default: 0
145
+
qcom,hsdisc-trim-value:
146
+
description:
147
+
It is a 2 bit value tuning parameter that control disconnect
148
+
threshold and may vary for different boards of same SOC.
149
+
$ref: /schemas/types.yaml#/definitions/uint32
150
+
minimum: 0
151
+
maximum: 3
152
+
default: 0
160
153
161
154
required:
162
155
- compatible
···
161
168
- vdda-pll-supply
162
169
- vdda-phy-dpdm-supply
163
170
- resets
171
+
172
+
allOf:
173
+
- if:
174
+
not:
175
+
properties:
176
+
compatible:
177
+
contains:
178
+
const: qcom,qusb2-v2-phy
179
+
then:
180
+
properties:
181
+
qcom,imp-res-offset-value: false
182
+
qcom,bias-ctrl-value: false
183
+
qcom,charge-ctrl-value: false
184
+
qcom,hstx-trim-value: false
185
+
qcom,preemphasis-level: false
186
+
qcom,preemphasis-width: false
187
+
qcom,hsdisc-trim-value: false
164
188
165
189
additionalProperties: false
166
190