Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
kconfig: remove unneeded menu_is_visible() call in conf_write_defconfig()
When the condition 'sym == NULL' is met, the code will reach the
'next_menu' label regardless of the return value from menu_is_visible().
menu_is_visible() calculates some symbol values as a side-effect, for
instance by calling expr_calc_value(menu->visibility), but all the
symbol values will be calculated eventually.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
+1
-4
+1
-4
scripts/kconfig/confdata.c
+1
-4
scripts/kconfig/confdata.c
···
799
799
while (menu != NULL)
800
800
{
801
801
sym = menu->sym;
802
-
if (sym == NULL) {
803
-
if (!menu_is_visible(menu))
804
-
goto next_menu;
805
-
} else if (!sym_is_choice(sym)) {
802
+
if (sym && !sym_is_choice(sym)) {
806
803
sym_calc_value(sym);
807
804
if (!(sym->flags & SYMBOL_WRITE))
808
805
goto next_menu;