tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

uio: fsl_elbc_gpcm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/ca99d4e71054e8452f3cee6c016bf4f89bfc7eaa.1709933231.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Uwe Kleine-König and committed by
Greg Kroah-Hartman b2c6a73f 4bc4634e

+2 -4
+2 -4
drivers/uio/uio_fsl_elbc_gpcm.c
··· 427 427 return ret; 428 428 } 429 429 430 - static int uio_fsl_elbc_gpcm_remove(struct platform_device *pdev) 430 + static void uio_fsl_elbc_gpcm_remove(struct platform_device *pdev) 431 431 { 432 432 struct uio_info *info = platform_get_drvdata(pdev); 433 433 struct fsl_elbc_gpcm *priv = info->priv; ··· 437 437 if (priv->shutdown) 438 438 priv->shutdown(info, false); 439 439 iounmap(info->mem[0].internal_addr); 440 - 441 - return 0; 442 440 443 441 } 444 442 ··· 453 455 .dev_groups = uio_fsl_elbc_gpcm_groups, 454 456 }, 455 457 .probe = uio_fsl_elbc_gpcm_probe, 456 - .remove = uio_fsl_elbc_gpcm_remove, 458 + .remove_new = uio_fsl_elbc_gpcm_remove, 457 459 }; 458 460 module_platform_driver(uio_fsl_elbc_gpcm_driver); 459 461