tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Input: synaptics_i2c - replace use of system_wq with system_dfl_wq

Currently if a user enqueues a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

This patch continues the effort to refactor worqueue APIs, which has begun
with the change introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

This specific workload do not benefit from a per-cpu workqueue, so use
the default unbound workqueue (system_dfl_wq) instead.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Link: https://patch.msgid.link/20251106141955.218911-4-marco.crivellari@suse.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Marco Crivellari and committed by
Dmitry Torokhov b3ee88e2 a4fcf43b

+4 -4
+4 -4
drivers/input/mouse/synaptics_i2c.c
··· 372 372 { 373 373 struct synaptics_i2c *touch = dev_id; 374 374 375 - mod_delayed_work(system_wq, &touch->dwork, 0); 375 + mod_delayed_work(system_dfl_wq, &touch->dwork, 0); 376 376 377 377 return IRQ_HANDLED; 378 378 } ··· 448 448 * We poll the device once in THREAD_IRQ_SLEEP_SECS and 449 449 * if error is detected, we try to reset and reconfigure the touchpad. 450 450 */ 451 - mod_delayed_work(system_wq, &touch->dwork, delay); 451 + mod_delayed_work(system_dfl_wq, &touch->dwork, delay); 452 452 } 453 453 454 454 static int synaptics_i2c_open(struct input_dev *input) ··· 461 461 return ret; 462 462 463 463 if (polling_req) 464 - mod_delayed_work(system_wq, &touch->dwork, 464 + mod_delayed_work(system_dfl_wq, &touch->dwork, 465 465 msecs_to_jiffies(NO_DATA_SLEEP_MSECS)); 466 466 467 467 return 0; ··· 620 620 if (ret) 621 621 return ret; 622 622 623 - mod_delayed_work(system_wq, &touch->dwork, 623 + mod_delayed_work(system_dfl_wq, &touch->dwork, 624 624 msecs_to_jiffies(NO_DATA_SLEEP_MSECS)); 625 625 626 626 return 0;