Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
gpu: nova-core: gsp: warn if data remains after processing a message
Not processing the whole data from a received message is a strong
indicator of a bug - emit a warning when such cases are detected.
Reviewed-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Danilo Krummrich <dakr@kernel.org>
Link: https://patch.msgid.link/20260217-nova-misc-v3-1-b4e2d45eafbc@nvidia.com
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
+11
-1
+11
-1
drivers/gpu/nova-core/gsp/cmdq.rs
+11
-1
drivers/gpu/nova-core/gsp/cmdq.rs
···
674
674
let (cmd, contents_1) = M::Message::from_bytes_prefix(message.contents.0).ok_or(EIO)?;
675
675
let mut sbuffer = SBufferIter::new_reader([contents_1, message.contents.1]);
676
676
677
-
M::read(cmd, &mut sbuffer).map_err(|e| e.into())
677
+
M::read(cmd, &mut sbuffer)
678
+
.map_err(|e| e.into())
679
+
.inspect(|_| {
680
+
if !sbuffer.is_empty() {
681
+
dev_warn!(
682
+
&self.dev,
683
+
"GSP message {:?} has unprocessed data\n",
684
+
function
685
+
);
686
+
}
687
+
})
678
688
} else {
679
689
Err(ERANGE)
680
690
};