gve: Fix various typos and improve code comments

- Correct spelling and improves the clarity of comments
"confiugration" -> "configuration"
"spilt" -> "split"
"It if is 0" -> "If it is 0"
"DQ" -> "DQO" (correct abbreviation)
- Clarify BIT(0) flag usage in gve_get_priv_flags()
- Replaced hardcoded array size with GVE_NUM_PTYPES
for clarity and maintainability.

These changes are purely cosmetic and do not affect functionality.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Joe Damato <joe@dama.to>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Link: https://patch.msgid.link/20250616054504.1644770-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Alok Tiwari and committed by

Jakub Kicinski 1 year ago b52a93bb fb7612b6

+6 -6

5 changed files

expand all

drivers

net

ethernet

google

gve

gve.h

gve_adminq.c

gve_adminq.h

gve_ethtool.c

gve_main.c

+1 -1

drivers/net/ethernet/google/gve/gve.h

··· 789 789 790 790 struct gve_tx_queue_config tx_cfg; 791 791 struct gve_rx_queue_config rx_cfg; 792 - u32 num_ntfy_blks; /* spilt between TX and RX so must be even */ 792 + u32 num_ntfy_blks; /* split between TX and RX so must be even */ 793 793 794 794 struct gve_registers __iomem *reg_bar0; /* see gve_register.h */ 795 795 __be32 __iomem *db_bar2; /* "array" of doorbells */

+1 -1

drivers/net/ethernet/google/gve/gve_adminq.c

··· 650 650 651 651 /* The device specifies that the management vector can either be the first irq 652 652 * or the last irq. ntfy_blk_msix_base_idx indicates the first irq assigned to 653 - * the ntfy blks. It if is 0 then the management vector is last, if it is 1 then 653 + * the ntfy blks. If it is 0 then the management vector is last, if it is 1 then 654 654 * the management vector is first. 655 655 * 656 656 * gve arranges the msix vectors so that the management vector is last.

+1 -1

drivers/net/ethernet/google/gve/gve_adminq.h

··· 476 476 }; 477 477 478 478 struct gve_ptype_map { 479 - struct gve_ptype_entry ptypes[1 << 10]; /* PTYPES are always 10 bits. */ 479 + struct gve_ptype_entry ptypes[GVE_NUM_PTYPES]; /* PTYPES are always 10 bits. */ 480 480 }; 481 481 482 482 struct gve_adminq_get_ptype_map {

+1 -1

drivers/net/ethernet/google/gve/gve_ethtool.c

··· 668 668 struct gve_priv *priv = netdev_priv(netdev); 669 669 u32 ret_flags = 0; 670 670 671 - /* Only 1 flag exists currently: report-stats (BIT(O)), so set that flag. */ 671 + /* Only 1 flag exists currently: report-stats (BIT(0)), so set that flag. */ 672 672 if (priv->ethtool_flags & BIT(0)) 673 673 ret_flags |= BIT(0); 674 674 return ret_flags;

+2 -2

drivers/net/ethernet/google/gve/gve_main.c

··· 1733 1733 { 1734 1734 int err; 1735 1735 1736 - /* Allocate resources for the new confiugration */ 1736 + /* Allocate resources for the new configuration */ 1737 1737 err = gve_queues_mem_alloc(priv, tx_alloc_cfg, rx_alloc_cfg); 1738 1738 if (err) { 1739 1739 netif_err(priv, drv, priv->dev, ··· 2284 2284 goto err; 2285 2285 } 2286 2286 2287 - /* Big TCP is only supported on DQ*/ 2287 + /* Big TCP is only supported on DQO */ 2288 2288 if (!gve_is_gqi(priv)) 2289 2289 netif_set_tso_max_size(priv->dev, GVE_DQO_TX_MAX); 2290 2290

Configure Feed

Configure Feed