Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: phy: realtek: use generic MDIO helpers to simplify the code

Use generic MDIO helpers to simplify the code.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/422ae70f-7305-45fd-ab3e-0dd604b9fd6c@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Heiner Kallweit and committed by
Jakub Kicinski
b63cc733 d0466c7f

+3 -17
+3 -17
drivers/net/phy/realtek.c
··· 680 680 int ret = 0; 681 681 682 682 if (phydev->autoneg == AUTONEG_ENABLE) { 683 - u16 adv = 0; 684 - 685 - if (linkmode_test_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, 686 - phydev->advertising)) 687 - adv |= MDIO_AN_10GBT_CTRL_ADV2_5G; 688 - if (linkmode_test_bit(ETHTOOL_LINK_MODE_5000baseT_Full_BIT, 689 - phydev->advertising)) 690 - adv |= MDIO_AN_10GBT_CTRL_ADV5G; 683 + u16 adv = linkmode_adv_to_mii_10gbt_adv_t(phydev->advertising); 691 684 692 685 ret = phy_modify_paged_changed(phydev, 0xa5d, 0x12, 693 686 MDIO_AN_10GBT_CTRL_ADV2_5G | ··· 703 710 if (lpadv < 0) 704 711 return lpadv; 705 712 706 - linkmode_mod_bit(ETHTOOL_LINK_MODE_10000baseT_Full_BIT, 707 - phydev->lp_advertising, 708 - lpadv & MDIO_AN_10GBT_STAT_LP10G); 709 - linkmode_mod_bit(ETHTOOL_LINK_MODE_5000baseT_Full_BIT, 710 - phydev->lp_advertising, 711 - lpadv & MDIO_AN_10GBT_STAT_LP5G); 712 - linkmode_mod_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, 713 - phydev->lp_advertising, 714 - lpadv & MDIO_AN_10GBT_STAT_LP2_5G); 713 + mii_10gbt_stat_mod_linkmode_lpa_t(phydev->lp_advertising, 714 + lpadv); 715 715 } 716 716 717 717 ret = genphy_read_status(phydev);