tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PCI: hv: Fix double ida_free in hv_pci_probe error path

If hv_pci_probe() fails after storing the domain number in
hbus->bridge->domain_nr, there is a call to free this domain_nr via
pci_bus_release_emul_domain_nr(), however, during cleanup, the bridge
release callback pci_release_host_bridge_dev() also frees the domain_nr
causing ida_free to be called on same ID twice and triggering following
warning:

ida_free called for id=28971 which is not allocated.
WARNING: lib/idr.c:594 at ida_free+0xdf/0x160, CPU#0: kworker/0:2/198
Call Trace:
pci_bus_release_emul_domain_nr+0x17/0x20
pci_release_host_bridge_dev+0x4b/0x60
device_release+0x3b/0xa0
kobject_put+0x8e/0x220
devm_pci_alloc_host_bridge_release+0xe/0x20
devres_release_all+0x9a/0xd0
device_unbind_cleanup+0x12/0xa0
really_probe+0x1c5/0x3f0
vmbus_add_channel_work+0x135/0x1a0

Fix this by letting pci core handle the free domain_nr and remove
the explicit free called in pci-hyperv driver.

Fixes: bcce8c74f1ce ("PCI: Enable host bridge emulation for PCI_DOMAINS_GENERIC platforms")
Signed-off-by: Sahil Chandna <sahilchandna@linux.microsoft.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Signed-off-by: Wei Liu <wei.liu@kernel.org>

authored by

Sahil Chandna and committed by
Wei Liu b6422dff 7b3b1e5a

+1 -3
+1 -3
drivers/pci/controller/pci-hyperv.c
··· 3786 3786 hbus->bridge->domain_nr); 3787 3787 if (!hbus->wq) { 3788 3788 ret = -ENOMEM; 3789 - goto free_dom; 3789 + goto free_bus; 3790 3790 } 3791 3791 3792 3792 hdev->channel->next_request_id_callback = vmbus_next_request_id; ··· 3882 3882 vmbus_close(hdev->channel); 3883 3883 destroy_wq: 3884 3884 destroy_workqueue(hbus->wq); 3885 - free_dom: 3886 - pci_bus_release_emul_domain_nr(hbus->bridge->domain_nr); 3887 3885 free_bus: 3888 3886 kfree(hbus); 3889 3887 return ret;