Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

runtime constants: deal with old decrepit linkers

The runtime constants linker script depended on documented linker
behavior [1]:

"If an output section’s name is the same as the input section’s name
and is representable as a C identifier, then the linker will
automatically PROVIDE two symbols: __start_SECNAME and __stop_SECNAME,
where SECNAME is the name of the section. These indicate the start
address and end address of the output section respectively"

to just automatically define the symbol names for the bounds of the
runtime constant arrays.

It turns out that this isn't actually something we can rely on, with old
linkers not generating these automatic symbols. It looks to have been
introduced in binutils-2.29 back in 2017, and we still support building
with versions all the way back to binutils-2.25 (from 2015).

And yes, Oleg actually seems to be using such ancient versions of
binutils.

So instead of depending on the implicit symbols from "section names
match and are representable C identifiers", just do this all manually.
It's not like it causes us any extra pain, we already have to do that
for all the other sections that we use that often have special
characters in them.

Reported-and-tested-by: Oleg Nesterov <oleg@redhat.com>
Link: https://sourceware.org/binutils/docs/ld/Input-Section-Example.html [1]
Link: https://lore.kernel.org/all/20240802114518.GA20924@redhat.com/
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

+5 -6
+5 -6
include/asm-generic/vmlinux.lds.h
··· 911 911 #define CON_INITCALL \ 912 912 BOUNDED_SECTION_POST_LABEL(.con_initcall.init, __con_initcall, _start, _end) 913 913 914 - #define RUNTIME_NAME(t,x) runtime_##t##_##x 914 + #define NAMED_SECTION(name) \ 915 + . = ALIGN(8); \ 916 + name : AT(ADDR(name) - LOAD_OFFSET) \ 917 + { BOUNDED_SECTION_PRE_LABEL(name, name, __start_, __stop_) } 915 918 916 - #define RUNTIME_CONST(t,x) \ 917 - . = ALIGN(8); \ 918 - RUNTIME_NAME(t,x) : AT(ADDR(RUNTIME_NAME(t,x)) - LOAD_OFFSET) { \ 919 - *(RUNTIME_NAME(t,x)); \ 920 - } 919 + #define RUNTIME_CONST(t,x) NAMED_SECTION(runtime_##t##_##x) 921 920 922 921 /* Alignment must be consistent with (kunit_suite *) in include/kunit/test.h */ 923 922 #define KUNIT_TABLE() \