tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

KVM: selftests: Add missing close and munmap in __vm_mem_region_delete()

Deleting a memslot (when freeing a VM) is not closing the backing fd,
nor it's unmapping the alias mapping. Fix by adding the missing close
and munmap.

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
Reviewed-by: Oliver Upton <oupton@google.com>
Reviewed-by: Ben Gardon <bgardon@google.com>
Signed-off-by: Ricardo Koller <ricarkol@google.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221017195834.2295901-4-ricarkol@google.com

authored by

Ricardo Koller and committed by
Marc Zyngier b6b03b86 228f324d

+6
+6
tools/testing/selftests/kvm/lib/kvm_util.c
··· 586 586 sparsebit_free(&region->unused_phy_pages); 587 587 ret = munmap(region->mmap_start, region->mmap_size); 588 588 TEST_ASSERT(!ret, __KVM_SYSCALL_ERROR("munmap()", ret)); 589 + if (region->fd >= 0) { 590 + /* There's an extra map when using shared memory. */ 591 + ret = munmap(region->mmap_alias, region->mmap_size); 592 + TEST_ASSERT(!ret, __KVM_SYSCALL_ERROR("munmap()", ret)); 593 + close(region->fd); 594 + } 589 595 590 596 free(region); 591 597 }