Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

padata: replace use of system_unbound_wq with system_dfl_wq

Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistentcy cannot be addressed without refactoring the API.

system_unbound_wq should be the default workqueue so as not to enforce
locality constraints for random work whenever it's not required.

Adding system_dfl_wq to encourage its use when unbound work should be used.

queue_work() / queue_delayed_work() / mod_delayed_work() will now use the
new unbound wq: whether the user still use the old wq a warn will be
printed along with a wq redirect to the new one.

The old system_unbound_wq will be kept for a few release cycles.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Marco Crivellari and committed by
Herbert Xu
b6d02e0e a5d71f01

+2 -2
+2 -2
kernel/padata.c
··· 490 490 do { 491 491 nid = next_node_in(old_node, node_states[N_CPU]); 492 492 } while (!atomic_try_cmpxchg(&last_used_nid, &old_node, nid)); 493 - queue_work_node(nid, system_unbound_wq, &pw->pw_work); 493 + queue_work_node(nid, system_dfl_wq, &pw->pw_work); 494 494 } else { 495 - queue_work(system_unbound_wq, &pw->pw_work); 495 + queue_work(system_dfl_wq, &pw->pw_work); 496 496 } 497 497 498 498 /* Use the current thread, which saves starting a workqueue worker. */