powerpc: Remove UDBG_RTAS_CONSOLE

The IBM Cell blade support was the last user of UDBG_RTAS_CONSOLE.

Although it's still possible to build it via
PPC_EARLY_DEBUG_UDBG_RTAS_CONSOLE, AFAIK it's not useful on any
other platfoms, because only Cell and JS20 era machines provided the
RTAS get/put-term-char functions.

If anyone is using it or needs it we can always resurrect it from git.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20241218105523.416573-19-mpe@ellerman.id.au

authored by

Michael Ellerman and committed by

Madhavan Srinivasan 1 year ago b78e0bff 1b52e091

-89

4 changed files

expand all

arch

powerpc

Kconfig.debug

kernel

rtas.c

udbg.c

platforms

Kconfig

-7

arch/powerpc/Kconfig.debug

··· 216 216 help 217 217 Select this to enable early debugging via the RTAS panel. 218 218 219 - config PPC_EARLY_DEBUG_RTAS_CONSOLE 220 - bool "RTAS Console" 221 - depends on PPC_RTAS 222 - select UDBG_RTAS_CONSOLE 223 - help 224 - Select this to enable early debugging via the RTAS console. 225 - 226 219 config PPC_EARLY_DEBUG_PAS_REALMODE 227 220 bool "PA Semi real mode" 228 221 depends on PPC_PASEMI

-75

arch/powerpc/kernel/rtas.c

··· 798 798 udbg_putc = call_rtas_display_status_delay; 799 799 } 800 800 801 - #ifdef CONFIG_UDBG_RTAS_CONSOLE 802 - 803 - /* If you think you're dying before early_init_dt_scan_rtas() does its 804 - * work, you can hard code the token values for your firmware here and 805 - * hardcode rtas.base/entry etc. 806 - */ 807 - static unsigned int rtas_putchar_token = RTAS_UNKNOWN_SERVICE; 808 - static unsigned int rtas_getchar_token = RTAS_UNKNOWN_SERVICE; 809 - 810 - static void udbg_rtascon_putc(char c) 811 - { 812 - int tries; 813 - 814 - if (!rtas.base) 815 - return; 816 - 817 - /* Add CRs before LFs */ 818 - if (c == '\n') 819 - udbg_rtascon_putc('\r'); 820 - 821 - /* if there is more than one character to be displayed, wait a bit */ 822 - for (tries = 0; tries < 16; tries++) { 823 - if (rtas_call(rtas_putchar_token, 1, 1, NULL, c) == 0) 824 - break; 825 - udelay(1000); 826 - } 827 - } 828 - 829 - static int udbg_rtascon_getc_poll(void) 830 - { 831 - int c; 832 - 833 - if (!rtas.base) 834 - return -1; 835 - 836 - if (rtas_call(rtas_getchar_token, 0, 2, &c)) 837 - return -1; 838 - 839 - return c; 840 - } 841 - 842 - static int udbg_rtascon_getc(void) 843 - { 844 - int c; 845 - 846 - while ((c = udbg_rtascon_getc_poll()) == -1) 847 - ; 848 - 849 - return c; 850 - } 851 - 852 - 853 - void __init udbg_init_rtas_console(void) 854 - { 855 - udbg_putc = udbg_rtascon_putc; 856 - udbg_getc = udbg_rtascon_getc; 857 - udbg_getc_poll = udbg_rtascon_getc_poll; 858 - } 859 - #endif /* CONFIG_UDBG_RTAS_CONSOLE */ 860 - 861 801 void rtas_progress(char *s, unsigned short hex) 862 802 { 863 803 struct device_node *root; ··· 2074 2134 rtas.entry = *entryp; 2075 2135 rtas.size = *sizep; 2076 2136 } 2077 - 2078 - #ifdef CONFIG_UDBG_RTAS_CONSOLE 2079 - basep = of_get_flat_dt_prop(node, "put-term-char", NULL); 2080 - if (basep) 2081 - rtas_putchar_token = *basep; 2082 - 2083 - basep = of_get_flat_dt_prop(node, "get-term-char", NULL); 2084 - if (basep) 2085 - rtas_getchar_token = *basep; 2086 - 2087 - if (rtas_putchar_token != RTAS_UNKNOWN_SERVICE && 2088 - rtas_getchar_token != RTAS_UNKNOWN_SERVICE) 2089 - udbg_init_rtas_console(); 2090 - 2091 - #endif 2092 2137 2093 2138 /* break now */ 2094 2139 return 1;

-3

arch/powerpc/kernel/udbg.c

··· 36 36 #elif defined(CONFIG_PPC_EARLY_DEBUG_RTAS_PANEL) 37 37 /* RTAS panel debug */ 38 38 udbg_init_rtas_panel(); 39 - #elif defined(CONFIG_PPC_EARLY_DEBUG_RTAS_CONSOLE) 40 - /* RTAS console debug */ 41 - udbg_init_rtas_console(); 42 39 #elif defined(CONFIG_PPC_EARLY_DEBUG_PAS_REALMODE) 43 40 udbg_init_pas_realmode(); 44 41 #elif defined(CONFIG_PPC_EARLY_DEBUG_BOOTX)

-4

arch/powerpc/platforms/Kconfig

··· 70 70 firmware provides this binding. 71 71 If you're not sure say Y. 72 72 73 - config UDBG_RTAS_CONSOLE 74 - bool "RTAS based debug console" 75 - depends on PPC_RTAS 76 - 77 73 config PPC_SMP_MUXED_IPI 78 74 bool 79 75 help

Configure Feed

Configure Feed