tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: samsung: spdif: Convert to devm_ioremap_resource()

Replace the open-coded request_mem_region() + ioremap() sequence with
devm_ioremap_resource(), which handles both the region claim and mapping
under devres lifetime management.

This eliminates the manual iounmap() and release_mem_region() calls in
the error path (err3/err4 labels) and in spdif_remove(), simplifying
the probe error handling.

Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
Link: https://patch.msgid.link/20260324223907.98897-1-jihed.chaibi.dev@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Jihed Chaibi and committed by
Mark Brown b81f6310 2a740dc5

+5 -24
+5 -24
sound/soc/samsung/spdif.c
··· 407 407 if (ret) 408 408 goto err1; 409 409 410 - /* Request S/PDIF Register's memory region */ 411 - if (!request_mem_region(mem_res->start, 412 - resource_size(mem_res), "samsung-spdif")) { 413 - dev_err(&pdev->dev, "Unable to request register region\n"); 414 - ret = -EBUSY; 410 + spdif->regs = devm_ioremap_resource(&pdev->dev, mem_res); 411 + if (IS_ERR(spdif->regs)) { 412 + ret = PTR_ERR(spdif->regs); 415 413 goto err2; 416 - } 417 - 418 - spdif->regs = ioremap(mem_res->start, 0x100); 419 - if (spdif->regs == NULL) { 420 - dev_err(&pdev->dev, "Cannot ioremap registers\n"); 421 - ret = -ENXIO; 422 - goto err3; 423 414 } 424 415 425 416 spdif_stereo_out.addr_width = 2; ··· 426 435 NULL, NULL, NULL); 427 436 if (ret) { 428 437 dev_err(&pdev->dev, "failed to register DMA: %d\n", ret); 429 - goto err4; 438 + goto err2; 430 439 } 431 440 432 441 dev_set_drvdata(&pdev->dev, spdif); ··· 435 444 &samsung_spdif_component, &samsung_spdif_dai, 1); 436 445 if (ret != 0) { 437 446 dev_err(&pdev->dev, "fail to register dai\n"); 438 - goto err4; 447 + goto err2; 439 448 } 440 449 441 450 return 0; 442 - err4: 443 - iounmap(spdif->regs); 444 - err3: 445 - release_mem_region(mem_res->start, resource_size(mem_res)); 446 451 err2: 447 452 clk_disable_unprepare(spdif->sclk); 448 453 err1: ··· 450 463 static void spdif_remove(struct platform_device *pdev) 451 464 { 452 465 struct samsung_spdif_info *spdif = &spdif_info; 453 - struct resource *mem_res; 454 - 455 - iounmap(spdif->regs); 456 - 457 - mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 458 - release_mem_region(mem_res->start, resource_size(mem_res)); 459 466 460 467 clk_disable_unprepare(spdif->sclk); 461 468 clk_disable_unprepare(spdif->pclk);