tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/memory_hotplug: update comment regarding zone shuffling

As we no longer shuffle via generic_online_page() and when undoing
isolation, we can simplify the comment.

We now effectively shuffle only once (properly) when onlining new memory.

Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Wei Yang <richard.weiyang@linux.alibaba.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Scott Cheloha <cheloha@linux.ibm.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>
Link: https://lkml.kernel.org/r/20201005121534.15649-6-david@redhat.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

David Hildenbrand and committed by
Linus Torvalds b86c5fc4 7fef431b

+4 -7
+4 -7
mm/memory_hotplug.c
··· 858 858 undo_isolate_page_range(pfn, pfn + nr_pages, MIGRATE_MOVABLE); 859 859 860 860 /* 861 - * When exposing larger, physically contiguous memory areas to the 862 - * buddy, shuffling in the buddy (when freeing onlined pages, putting 863 - * them either to the head or the tail of the freelist) is only helpful 864 - * for maintaining the shuffle, but not for creating the initial 865 - * shuffle. Shuffle the whole zone to make sure the just onlined pages 866 - * are properly distributed across the whole freelist. Make sure to 867 - * shuffle once pageblocks are no longer isolated. 861 + * Freshly onlined pages aren't shuffled (e.g., all pages are placed to 862 + * the tail of the freelist when undoing isolation). Shuffle the whole 863 + * zone to make sure the just onlined pages are properly distributed 864 + * across the whole freelist - to create an initial shuffle. 868 865 */ 869 866 shuffle_zone(zone); 870 867