tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/amdgpu: Expand kernel-doc in amdgpu_ring

Expand the kernel-doc about amdgpu_ring and add some tiny improvements.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Timur Kristóf <timur.kristof@gmail.com>
Signed-off-by: Rodrigo Siqueira <siqueira@igalia.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Rodrigo Siqueira and committed by
Alex Deucher b9befc9a e06d1942

+10 -3
+8 -3
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
··· 76 76 * @ring: amdgpu_ring structure holding ring information 77 77 * @ndw: number of dwords to allocate in the ring buffer 78 78 * 79 - * Allocate @ndw dwords in the ring buffer (all asics). 80 - * Returns 0 on success, error on failure. 79 + * Allocate @ndw dwords in the ring buffer. The number of dwords should be the 80 + * sum of all commands written to the ring. 81 + * 82 + * Returns: 83 + * 0 on success, otherwise -ENOMEM if it tries to allocate more than the 84 + * maximum dword allowed for one submission. 81 85 */ 82 86 int amdgpu_ring_alloc(struct amdgpu_ring *ring, unsigned int ndw) 83 87 { ··· 127 123 ring->funcs->begin_use(ring); 128 124 } 129 125 130 - /** amdgpu_ring_insert_nop - insert NOP packets 126 + /** 127 + * amdgpu_ring_insert_nop - insert NOP packets 131 128 * 132 129 * @ring: amdgpu_ring structure holding ring information 133 130 * @count: the number of NOP packets to insert
+2
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h
··· 62 62 #define AMDGPU_FENCE_FLAG_64BIT (1 << 0) 63 63 #define AMDGPU_FENCE_FLAG_INT (1 << 1) 64 64 #define AMDGPU_FENCE_FLAG_TC_WB_ONLY (1 << 2) 65 + 66 + /* Ensure the execution in case of preemption or reset */ 65 67 #define AMDGPU_FENCE_FLAG_EXEC (1 << 3) 66 68 67 69 #define to_amdgpu_ring(s) container_of((s), struct amdgpu_ring, sched)