tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ima: Fix documentation-related warnings in ima_main.c

Fix the following warnings in ima_main.c, displayed with W=n make argument:

security/integrity/ima/ima_main.c:432: warning: Function parameter or
member 'vma' not described in 'ima_file_mprotect'
security/integrity/ima/ima_main.c:636: warning: Function parameter or
member 'inode' not described in 'ima_post_create_tmpfile'
security/integrity/ima/ima_main.c:636: warning: Excess function parameter
'file' description in 'ima_post_create_tmpfile'
security/integrity/ima/ima_main.c:843: warning: Function parameter or
member 'load_id' not described in 'ima_post_load_data'
security/integrity/ima/ima_main.c:843: warning: Excess function parameter
'id' description in 'ima_post_load_data'

Also, fix some style issues in the description of ima_post_create_tmpfile()
and ima_post_path_mknod().

Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Link: https://lore.kernel.org/bpf/20220302111404.193900-2-roberto.sassu@huawei.com

authored by

Roberto Sassu and committed by
Alexei Starovoitov bae60eef 357b3cc3

+6 -5
+6 -5
security/integrity/ima/ima_main.c
··· 418 418 419 419 /** 420 420 * ima_file_mprotect - based on policy, limit mprotect change 421 + * @vma: vm_area_struct protection is set to 421 422 * @prot: contains the protection that will be applied by the kernel. 422 423 * 423 424 * Files can be mmap'ed read/write and later changed to execute to circumvent ··· 611 610 612 611 /** 613 612 * ima_post_create_tmpfile - mark newly created tmpfile as new 614 - * @mnt_userns: user namespace of the mount the inode was found from 615 - * @file : newly created tmpfile 613 + * @mnt_userns: user namespace of the mount the inode was found from 614 + * @inode: inode of the newly created tmpfile 616 615 * 617 616 * No measuring, appraising or auditing of newly created tmpfiles is needed. 618 617 * Skip calling process_measurement(), but indicate which newly, created ··· 644 643 645 644 /** 646 645 * ima_post_path_mknod - mark as a new inode 647 - * @mnt_userns: user namespace of the mount the inode was found from 646 + * @mnt_userns: user namespace of the mount the inode was found from 648 647 * @dentry: newly created dentry 649 648 * 650 649 * Mark files created via the mknodat syscall as new, so that the ··· 815 814 * ima_post_load_data - appraise decision based on policy 816 815 * @buf: pointer to in memory file contents 817 816 * @size: size of in memory file contents 818 - * @id: kernel load data caller identifier 819 - * @description: @id-specific description of contents 817 + * @load_id: kernel load data caller identifier 818 + * @description: @load_id-specific description of contents 820 819 * 821 820 * Measure/appraise/audit in memory buffer based on policy. Policy rules 822 821 * are written in terms of a policy identifier.