tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/amd/pm/ci: Fill DW8 fields from SMC

In ci_populate_dw8() we currently just read a value from the SMU
and then throw it away. Instead of throwing away the value,
we should use it to fill other fields in DW8 (like radeon).

Otherwise the value of the other fiels is just cleared when
we copy this data to the SMU later.

Fixes: 9f4b35411cfe ("drm/amd/powerplay: add CI asics support to smumgr (v3)")
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Timur Kristóf and committed by
Alex Deucher baf28ec5 5facfd4c

+1 -2
+1 -2
drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c
··· 543 543 { 544 544 struct ci_smumgr *smu_data = (struct ci_smumgr *)(hwmgr->smu_backend); 545 545 const struct ci_pt_defaults *defaults = smu_data->power_tune_defaults; 546 - uint32_t temp; 547 546 548 547 if (ci_read_smc_sram_dword(hwmgr, 549 548 fuse_table_offset + 550 549 offsetof(SMU7_Discrete_PmFuses, TdcWaterfallCtl), 551 - (uint32_t *)&temp, SMC_RAM_END)) 550 + (uint32_t *)&smu_data->power_tune_table.TdcWaterfallCtl, SMC_RAM_END)) 552 551 PP_ASSERT_WITH_CODE(false, 553 552 "Attempt to read PmFuses.DW6 (SviLoadLineEn) from SMC Failed!", 554 553 return -EINVAL);