tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

usb: ehci-orion: remove optional PHY handling code remnants

Since the USB core code handles the generic USB PHYs automatically, the
optional PHY handling code has been removed from the 'ehci-orion' driver
entirely by commit e04585184dcf ("usb: ehci-orion: avoid double PHY
initialization"). However, the devm_phy_optional_get() call has been kept
so the driver still gets the PHY even though it is not used for anything
in the driver.

Drop the remaining code, and also remove the 'phy' member of the
'orion_ehci_hcd' structure to simplify the code.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://patch.msgid.link/20260221-ehci-orion-drop-phy-handling-v2-1-5e26aa73790b@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Gabor Juhos and committed by
Greg Kroah-Hartman bb24a1c0 dc3cf736

-9
-9
drivers/usb/host/ehci-orion.c
··· 12 12 #include <linux/clk.h> 13 13 #include <linux/platform_data/usb-ehci-orion.h> 14 14 #include <linux/of.h> 15 - #include <linux/phy/phy.h> 16 15 #include <linux/usb.h> 17 16 #include <linux/usb/hcd.h> 18 17 #include <linux/io.h> ··· 59 60 60 61 struct orion_ehci_hcd { 61 62 struct clk *clk; 62 - struct phy *phy; 63 63 }; 64 64 65 65 static struct hc_driver __read_mostly ehci_orion_hc_driver; ··· 272 274 err = clk_prepare_enable(priv->clk); 273 275 if (err) 274 276 goto err_put_hcd; 275 - } 276 - 277 - priv->phy = devm_phy_optional_get(&pdev->dev, "usb"); 278 - if (IS_ERR(priv->phy)) { 279 - err = PTR_ERR(priv->phy); 280 - if (err != -ENOSYS) 281 - goto err_dis_clk; 282 277 } 283 278 284 279 /*