tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

tg3: Fix race for querying speed/duplex

When driver signals carrier up via netif_carrier_on() its internal
link_up state isn't updated immediately. This leads to inconsistent
speed/duplex in /proc/net/bonding/bondX where the speed and duplex
is shown as unknown while ethtool shows correct values. Fix this by
using netif_carrier_ok() for link checking in get_ksettings function.

Fixes: 84421b99cedc ("tg3: Update link_up flag for phylib devices")
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Thomas Bogendoerfer and committed by
David S. Miller bb417456 5e67ba9b

+1 -1
+1 -1
drivers/net/ethernet/broadcom/tg3.c
··· 12299 12299 ethtool_convert_legacy_u32_to_link_mode(cmd->link_modes.advertising, 12300 12300 advertising); 12301 12301 12302 - if (netif_running(dev) && tp->link_up) { 12302 + if (netif_running(dev) && netif_carrier_ok(dev)) { 12303 12303 cmd->base.speed = tp->link_config.active_speed; 12304 12304 cmd->base.duplex = tp->link_config.active_duplex; 12305 12305 ethtool_convert_legacy_u32_to_link_mode(