Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/bridge: ti-sn65dsi86: Use dev_err_probe() to avoid polluting the log
If devm_drm_of_get_bridge() can't find the connected bridge, it returns an
ERR_PTR(-EPROBE_DEFER) to indicate that the probe should be deferred.
But this path also prints an error message, which pollutes the kernel log
since is printed on every probe deferral, i.e:
$ dmesg | grep "failed to create panel bridge" | wc -l
38
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220722074755.660258-1-javierm@redhat.com
+3
-4
+3
-4
drivers/gpu/drm/bridge/ti-sn65dsi86.c
+3
-4
drivers/gpu/drm/bridge/ti-sn65dsi86.c
···
1206
1206
int ret;
1207
1207
1208
1208
pdata->next_bridge = devm_drm_of_get_bridge(pdata->dev, np, 1, 0);
1209
-
if (IS_ERR(pdata->next_bridge)) {
1210
-
DRM_ERROR("failed to create panel bridge\n");
1211
-
return PTR_ERR(pdata->next_bridge);
1212
-
}
1209
+
if (IS_ERR(pdata->next_bridge))
1210
+
return dev_err_probe(pdata->dev, PTR_ERR(pdata->next_bridge),
1211
+
"failed to create panel bridge\n");
1213
1212
1214
1213
ti_sn_bridge_parse_lanes(pdata, np);
1215
1214