tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

rtnetlink: Fix an error handling path in rtnl_newlink()

When some code has been moved in the commit in Fixes, some "return err;"
have correctly been changed in goto <some_where_in_the_error_handling_path>
but this one was missed.

Should "ops->maxtype > RTNL_MAX_TYPE" happen, then some resources would
leak.

Go through the error handling path to fix these leaks.

Fixes: 0d3008d1a9ae ("rtnetlink: Move ops->validate to rtnl_newlink().")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/eca90eeb4d9e9a0545772b68aeaab883d9fe2279.1729952228.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Christophe JAILLET and committed by
Jakub Kicinski bd03e762 1aea2c42

+4 -2
+4 -2
net/core/rtnetlink.c
··· 3840 3840 } 3841 3841 3842 3842 if (ops) { 3843 - if (ops->maxtype > RTNL_MAX_TYPE) 3844 - return -EINVAL; 3843 + if (ops->maxtype > RTNL_MAX_TYPE) { 3844 + ret = -EINVAL; 3845 + goto put_ops; 3846 + } 3845 3847 3846 3848 if (ops->maxtype && linkinfo[IFLA_INFO_DATA]) { 3847 3849 ret = nla_parse_nested_deprecated(tbs->attr, ops->maxtype,