Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
tools/sched_ext: Add error logging for dsq creation failures in remaining schedulers
Add scx_bpf_error() calls when scx_bpf_create_dsq() fails in the remaining
schedulers to improve debuggability:
- scx_simple.bpf.c: simple_init()
- scx_sdt.bpf.c: sdt_init()
- scx_cpu0.bpf.c: cpu0_init()
- scx_flatcg.bpf.c: fcg_init()
This follows the same pattern established in commit 2f8d489897ae
("sched_ext: Add error logging for dsq creation failures") for other
schedulers and ensures consistent error reporting across all schedulers.
Signed-off-by: zhidao su <suzhidao@xiaomi.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
+34
-4
+9
-1
tools/sched_ext/scx_cpu0.bpf.c
+9
-1
tools/sched_ext/scx_cpu0.bpf.c
···
71
71
72
72
s32 BPF_STRUCT_OPS_SLEEPABLE(cpu0_init)
73
73
{
74
-
return scx_bpf_create_dsq(DSQ_CPU0, -1);
74
+
int ret;
75
+
76
+
ret = scx_bpf_create_dsq(DSQ_CPU0, -1);
77
+
if (ret) {
78
+
scx_bpf_error("failed to create DSQ %d (%d)", DSQ_CPU0, ret);
79
+
return ret;
80
+
}
81
+
82
+
return 0;
75
83
}
76
84
77
85
void BPF_STRUCT_OPS(cpu0_exit, struct scx_exit_info *ei)
+9
-1
tools/sched_ext/scx_flatcg.bpf.c
+9
-1
tools/sched_ext/scx_flatcg.bpf.c
···
929
929
930
930
s32 BPF_STRUCT_OPS_SLEEPABLE(fcg_init)
931
931
{
932
-
return scx_bpf_create_dsq(FALLBACK_DSQ, -1);
932
+
int ret;
933
+
934
+
ret = scx_bpf_create_dsq(FALLBACK_DSQ, -1);
935
+
if (ret) {
936
+
scx_bpf_error("failed to create DSQ %d (%d)", FALLBACK_DSQ, ret);
937
+
return ret;
938
+
}
939
+
940
+
return 0;
933
941
}
934
942
935
943
void BPF_STRUCT_OPS(fcg_exit, struct scx_exit_info *ei)
+7
-1
tools/sched_ext/scx_sdt.bpf.c
+7
-1
tools/sched_ext/scx_sdt.bpf.c
···
691
691
return ret;
692
692
}
693
693
694
-
return scx_bpf_create_dsq(SHARED_DSQ, -1);
694
+
ret = scx_bpf_create_dsq(SHARED_DSQ, -1);
695
+
if (ret) {
696
+
scx_bpf_error("failed to create DSQ %d (%d)", SHARED_DSQ, ret);
697
+
return ret;
698
+
}
699
+
700
+
return 0;
695
701
}
696
702
697
703
void BPF_STRUCT_OPS(sdt_exit, struct scx_exit_info *ei)
+9
-1
tools/sched_ext/scx_simple.bpf.c
+9
-1
tools/sched_ext/scx_simple.bpf.c
···
131
131
132
132
s32 BPF_STRUCT_OPS_SLEEPABLE(simple_init)
133
133
{
134
-
return scx_bpf_create_dsq(SHARED_DSQ, -1);
134
+
int ret;
135
+
136
+
ret = scx_bpf_create_dsq(SHARED_DSQ, -1);
137
+
if (ret) {
138
+
scx_bpf_error("failed to create DSQ %d (%d)", SHARED_DSQ, ret);
139
+
return ret;
140
+
}
141
+
142
+
return 0;
135
143
}
136
144
137
145
void BPF_STRUCT_OPS(simple_exit, struct scx_exit_info *ei)