tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/amd/pm: use int type to store negative error codes

Use int instead of uint32_t for 'ret' variable to store negative error
codes or zero returned by other functions.

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but can be confusing. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Qianfeng Rong and committed by
Alex Deucher bddf3094 a0556587

+3 -3
+1 -1
drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.c
··· 1032 1032 data->clock_vol_info.vdd_dep_on_fclk; 1033 1033 uint32_t i, now, size = 0; 1034 1034 uint32_t min_freq, max_freq = 0; 1035 - uint32_t ret = 0; 1035 + int ret = 0; 1036 1036 1037 1037 switch (type) { 1038 1038 case PP_SCLK:
+1 -1
drivers/gpu/drm/amd/pm/powerplay/smumgr/smu7_smumgr.c
··· 401 401 int smu7_check_fw_load_finish(struct pp_hwmgr *hwmgr, uint32_t fw_type) 402 402 { 403 403 struct smu7_smumgr *smu_data = (struct smu7_smumgr *)(hwmgr->smu_backend); 404 - uint32_t ret; 404 + int ret; 405 405 406 406 ret = phm_wait_on_indirect_register(hwmgr, mmSMC_IND_INDEX_11, 407 407 smu_data->soft_regs_start + smum_get_offsetof(hwmgr,
+1 -1
drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
··· 470 470 static int renoir_set_fine_grain_gfx_freq_parameters(struct smu_context *smu) 471 471 { 472 472 uint32_t min = 0, max = 0; 473 - uint32_t ret = 0; 473 + int ret = 0; 474 474 475 475 ret = smu_cmn_send_smc_msg_with_param(smu, 476 476 SMU_MSG_GetMinGfxclkFrequency,